Page MenuHomePhabricator

LuaEngineTestBase causes "Empty data set provided by data provider" failures for lua errors under PHPUnit 10
Open, Needs TriagePublic

Description

PHPUnit 10 marks empty data provider as invalid with the text "Empty data set provided by data provider" and count this as errors.

LuaEngineTestBase::provideLuaData catch all errors and returns an empty data provider,
resulting in the error "Empty data set provided by data provider", better to return the lua error here?

Needs another way to skip the tests, when this is wanted for lua errors.

Code is new from T337135 / dbf12c5dd44a0a52b1fac1e49511c93dcd376771

Event Timeline

Change #1258717 had a related patch set uploaded (by Arendpieter; author: Arendpieter):

[mediawiki/extensions/Scribunto@master] Fix "Empty data set provided by data provider" under PHPUnit 10

https://gerrit.wikimedia.org/r/1258717

@Umherirrender I’ve prepared a follow-up patch that fixes this.

@cscott I’ve replied to your comment on Gerrit.