Page MenuHomePhabricator
Create Task
Maniphest T420872

🧅 Create basic e2e tests for wbsearchentities
Closed, ResolvedPublic
Actions

Description

This seems like a good idea in general, especially now that we're making major changes to this code. A lot of the behavior is covered in SearchEntities(Integration)Test, so these tests don't have to be quite as elaborate as the corresponding REST API tests.

A good start would be:

  • find item(s) by label
  • find property by label
  • find item by ID
  • find item by URL
  • finds items if no type is specified
  • search and results in a different language

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
ActionAPI: Add wbsearchentities strictlanguage testsItamar Givonmediawiki/extensions/Wikibasemaster+136 -0
ActionAPI: Add wbsearchentities pagination testsItamar Givonmediawiki/extensions/Wikibasemaster+67 -19
ActionAPI: Move wbsearchentities testItamar Givonmediawiki/extensions/Wikibasemaster+53 -44
ActionAPI: Add wbsearchentities response structure testsItamar Givonmediawiki/extensions/Wikibasemaster+53 -0
ActionAPI: Add e2e tests for wbsearchentitiesItamar Givonmediawiki/extensions/Wikibasemaster+141 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Mar 23 2026, 4:13 AM
ItamarWMDE claimed this task.Mar 24 2026, 6:05 AM
ItamarWMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 65) board.
Restricted Application added a project: User-ItamarWMDE. · View Herald TranscriptMar 24 2026, 6:05 AM
gerritbot added a comment.Mar 24 2026, 4:06 PM

Change #1260019 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] ActionAPI: Add e2e tests for wbsearchentities

https://gerrit.wikimedia.org/r/1260019

gerritbot added a project: Patch-For-Review.Mar 24 2026, 4:06 PM
ItamarWMDE moved this task from Doing to Peer Review on the Wikibase Reuse Team (Sprint 65) board.Mar 24 2026, 4:22 PM
gerritbot added a comment.Mar 25 2026, 8:46 AM

Change #1260619 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] ActionAPI: Add wbsearchentities response structure tests

https://gerrit.wikimedia.org/r/1260619

gerritbot added a comment.Mar 25 2026, 9:33 AM

Change #1260634 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] ActionAPI: Add wbsearchentities limit and offset tests

https://gerrit.wikimedia.org/r/1260634

gerritbot added a comment.Mar 25 2026, 10:15 AM

Change #1260639 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] ActionAPI: Add wbsearchentities strictlanguage tests

https://gerrit.wikimedia.org/r/1260639

gerritbot added a comment.Mar 25 2026, 10:43 PM

Change #1260019 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] ActionAPI: Add e2e tests for wbsearchentities

https://gerrit.wikimedia.org/r/1260019

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.22; 2026-03-31).Mar 25 2026, 11:00 PM
gerritbot added a comment.Mar 26 2026, 1:42 AM

Change #1260619 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] ActionAPI: Add wbsearchentities response structure tests

https://gerrit.wikimedia.org/r/1260619

gerritbot added a comment.Mar 26 2026, 2:39 PM

Change #1261469 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] ActionApi: Move wbsearchentities test

https://gerrit.wikimedia.org/r/1261469

gerritbot added a comment.Mar 27 2026, 6:44 AM

Change #1261469 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] ActionAPI: Move wbsearchentities test

https://gerrit.wikimedia.org/r/1261469

gerritbot added a comment.Mar 31 2026, 4:17 AM

Change #1260634 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] ActionAPI: Add wbsearchentities pagination tests

https://gerrit.wikimedia.org/r/1260634

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.23; 2026-04-07); removed: MW-1.46-notes (1.46.0-wmf.22; 2026-03-31).Mar 31 2026, 5:01 AM
gerritbot added a comment.Apr 1 2026, 12:43 AM

Change #1260639 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] ActionAPI: Add wbsearchentities strictlanguage tests

https://gerrit.wikimedia.org/r/1260639

Maintenance_bot removed a project: Patch-For-Review.Apr 1 2026, 1:31 AM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Reuse Team (Sprint 65) board.Apr 1 2026, 2:19 AM
WMDE-leszek closed this task as Resolved.Apr 1 2026, 11:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits