| Dreamy_Jazz | |
| Mar 23 2026, 10:45 AM |
| F73518180: image.png | |
| Mar 23 2026, 10:45 AM |
https://doc.wikimedia.org/cover/mediawiki-core/ lists coverage for the Vector skin. It should not list it, as that is tracked in https://doc.wikimedia.org/cover-extensions/Vector/
phpunit.xml contains the skins folder (and extensions) folder and Vector is installed when running the coverage tests
<coverage includeUncoveredFiles="false"> <include> <directory suffix=".php">includes</directory> <directory suffix=".php">languages</directory> <directory suffix=".php">maintenance</directory> <directory suffix=".php">extensions</directory> <directory suffix=".php">skins</directory> </include> <exclude> <directory suffix=".php">languages/messages</directory> <directory suffix=".php">maintenance/benchmarks</directory> <directory suffix=".php">extensions/*/tests</directory> <directory suffix=".php">skins/*/tests</directory> </exclude> </coverage>
@Daimona could this be caused by your recent changes to out PHPUnit test infrastructure?
Hmmm I can't exclude it, but I don't immediately see how. The line that adds skins has been there for a few years, it's not new. AIUI, the way it works shouldn't have changed recently. Is it possible we've always had vector in the coverage report for core?
https://web.archive.org/web/20260113165531/https://doc.wikimedia.org/cover/mediawiki-core/ in mid Jan 2026 (latest scrape) it wasn't there
Yeah, I open this page frequently-ish to check coverage on code I modify. Its the first time I've seen it listed
The old suite.xml has only: (from d70bfcbb7d5dca229e0919f44e4cea644d7c1f31)
<coverage includeUncoveredFiles="true"> <include> <directory suffix=".php">../../includes</directory> <directory suffix=".php">../../maintenance</directory> </include> <exclude> <directory suffix=".php">../../maintenance/benchmarks</directory> </exclude> </coverage>
The coverage was changed from that entry point to the new one in 406bf8fd425a00479f11478ffd5406def07ac8a0
But with the update 41bfc04d919685d7e197eeef836de0e200a181e9 this seems to be used (for T419073).
Resulting in this new output.