Change #1266338 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):
[mediawiki/skins/Vector@master] Remove anon editor links code
Change #1266338 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Clean up anon editor links code and unused Hooks.php code
Change #1269962 had a related patch set uploaded (by Hashar; author: Hashar):
[mediawiki/skins/Vector@master] Revert "Clean up anon editor links code and unused Hooks.php code"
Change #1269962 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Revert "Clean up anon editor links code and unused Hooks.php code"
I have reverted https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1266338 because that broke CI ( T422907 ):
TypeError: array_map(): Argument #2 ($array) must be of type array, null given
from /workspace/src/skins/Vector/includes/Components/VectorComponentUserLinks.php(192)\n
#0 /workspace/src/skins/Vector/includes/Components/VectorComponentUserLinks.php(192): array_map()\n
#1 [internal function]: MediaWiki\Skins\Vector\Components\VectorComponentUserLinks::MediaWiki\Skins\Vector\Components\{closure}()\n
#2 /workspace/src/skins/Vector/includes/Components/VectorComponentUserLinks.php(188): array_map()\n
#3 [internal function]: MediaWiki\Skins\Vector\Components\VectorComponentUserLinks::MediaWiki\Skins\Vector\Components\{closure}()\n
#4 /workspace/src/skins/Vector/includes/Components/VectorComponentUserLinks.php(176): array_map()\n
#5 /workspace/src/skins/Vector/includes/Components/VectorComponentUserLinks.php(153): MediaWiki\Skins\Vector\Components\VectorComponentUserLinks::updateMenuItemStyles()\n
#6 /workspace/src/skins/Vector/includes/Components/VectorComponentUserLinks.php(362): MediaWiki\Skins\Vector\Components\VectorComponentUserLinks->getMenus()\n
...I have not looked at why the patch passed tests and got merged and then eventually led to other workflows to suddenly fail.
Change #1270074 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):
[mediawiki/skins/Vector@master] Clean up anon editor links code and unused Hooks.php code
Change #1270074 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Clean up anon editor links code and unused Hooks.php code
@hashar I've reopened T422907: CI tests fail with TypeError: array_map(): Argument #2 ($array) must be of type array, null given. The issue with why this test passed in Vector but not core seems like an open question outside the scope of this ticket. Left some pointers there on how we can resolve it, but feels off topic for this task.