Page MenuHomePhabricator
Create Task
Maniphest T421037

🧅 Create wbsearchentities controller(s) for items
Closed, ResolvedPublic
Actions

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Remove item ENTITY_SEARCH_CALLBACKJakobmediawiki/extensions/WikibaseCirrusSearchmaster+2 -8
Search: Use item-specific EntitySearchHelper in controllerJakobmediawiki/extensions/Wikibasemaster+55 -35
Move EntitySearchHelperFactory to service wiringJakobmediawiki/extensions/WikibaseCirrusSearchmaster+53 -26
Remove EntitySearchHelperFactoryJakobmediawiki/extensions/WikibaseCirrusSearchmaster+26 -69
Add wbsearchentities controllerJakobmediawiki/extensions/WikibaseCirrusSearchmaster+135 -1
Search: Use item-specific EntitySearchHelper in controllerJakobmediawiki/extensions/Wikibasemaster+42 -30
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Mar 24 2026, 7:35 AM
Jakob_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 65) board.
Jakob_WMDE mentioned this in T420683: 🧅 Create entity type specific controllers.Mar 24 2026, 7:37 AM
gerritbot added a comment.Mar 25 2026, 3:04 AM

Change #1260232 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseCirrusSearch@master] Add wbsearchentities controller

https://gerrit.wikimedia.org/r/1260232

gerritbot added a project: Patch-For-Review.Mar 25 2026, 3:04 AM
gerritbot added a comment.Mar 25 2026, 11:56 AM

Change #1260658 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Search: Use item-specific EntitySearchHelper in controller

https://gerrit.wikimedia.org/r/1260658

gerritbot added a comment.Mar 26 2026, 10:11 AM

Change #1261371 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] Search: Use item-specific EntitySearchHelper in controller

https://gerrit.wikimedia.org/r/1261371

gerritbot added a comment.Mar 27 2026, 1:46 AM

Change #1260658 abandoned by Jakob:

[mediawiki/extensions/Wikibase@master] Search: Use item-specific EntitySearchHelper in controller

Reason:

Abandoning in favor of If0680443240a5435280f02d9b28eae11227844fd

https://gerrit.wikimedia.org/r/1260658

gerritbot added a comment.Mar 27 2026, 1:47 AM

Change #1260232 abandoned by Jakob:

[mediawiki/extensions/WikibaseCirrusSearch@master] Add wbsearchentities controller

Reason:

Abandoning in favor of I8b0c20dc00687601f63a43a344307f2b5017da0f

https://gerrit.wikimedia.org/r/1260232

gerritbot added a comment.Mar 27 2026, 1:47 AM

Change #1261363 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseCirrusSearch@master] Extract EntitySearchHelper service to wiring

https://gerrit.wikimedia.org/r/1261363

gerritbot added a comment.Mar 27 2026, 2:13 AM

Change #1261730 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseCirrusSearch@master] Remove EntitySearchHelperFactory

https://gerrit.wikimedia.org/r/1261730

gerritbot added a comment.Mar 27 2026, 2:13 AM

Change #1261731 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseCirrusSearch@master] Remove item ENTITY_SEARCH_CALLBACK

https://gerrit.wikimedia.org/r/1261731

gerritbot added a comment.Mar 27 2026, 7:36 AM

Change #1261730 abandoned by Jakob:

[mediawiki/extensions/WikibaseCirrusSearch@master] Remove EntitySearchHelperFactory

Reason:

Realized the factory is needed to set the result language, which is a constructor param for some reason instead of a parameter on the method performing the search...

https://gerrit.wikimedia.org/r/1261730

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Reuse Team (Sprint 65) board.Mar 27 2026, 8:45 AM
gerritbot added a comment.Mar 30 2026, 11:53 AM

Change #1261363 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Move EntitySearchHelperFactory to service wiring

https://gerrit.wikimedia.org/r/1261363

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.22; 2026-03-31).Mar 30 2026, 12:00 PM
gerritbot added a comment.Mar 30 2026, 3:50 PM

Change #1261371 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Search: Use item-specific EntitySearchHelper in controller

https://gerrit.wikimedia.org/r/1261371

gerritbot added a comment.Mar 31 2026, 7:31 AM

Change #1261731 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Remove item ENTITY_SEARCH_CALLBACK

https://gerrit.wikimedia.org/r/1261731

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.23; 2026-04-07); removed: MW-1.46-notes (1.46.0-wmf.22; 2026-03-31).Mar 31 2026, 8:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 31 2026, 8:31 AM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Reuse Team (Sprint 65) board.Mar 31 2026, 9:03 AM
WMDE-leszek closed this task as Resolved.Apr 1 2026, 11:53 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits