Page MenuHomePhabricator

Add undo functionality to the editor
Closed, ResolvedPublicFeature

Description

Feature summary:
Users should be able to undo recent changes made while editing a banner.

Use case(s):
A user makes an unintended change while editing a banner and wants to revert it without having to manually redo their work or reload the editor.

Benefits:

  • Reverting accidental changes made during editing will be easier
  • Gives users more confidence to experiment with designs knowing they can step back

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Add basic undo functionalitytoolforge-repos/centralnotice-banner-editor!61ejeggundomain
Customize query in GitLab

Event Timeline

I've got a work in progress up on this branch: https://gitlab.wikimedia.org/ejegg/centralnotice-banner-editor/-/tree/undo . I think I need to re-evaluate the approach to tracking current state vs state-from-undo after taking a little break.

OK, the current MR seems more reliable than the version I had yesterday. I guess we probably want a redo button as well?

OK, the current MR seems more reliable than the version I had yesterday. I guess we probably want a redo button as well?

Thank you very much!
Yes, a redo button would be perfect.

OK, I've added another commit to the MR adding a redo button. It seems to work well in basic testing. After making multiple changes then undoing them, you can redo them, at least until you do any edit that is not an undo. Any other edit stops you being able to redo.