| mfossati | |
| Mar 24 2026, 3:55 PM |
| F76394029: ShareHighlight - transparent card in Preview with purple window background.png | |
| Fri, Apr 17, 3:19 PM |
| F76393976: ShareHighlight - transparent card in Preview with dark window background.png | |
| Fri, Apr 17, 3:19 PM |
| F76392234: ShareHighlights - transparent card in Notes.png | |
| Fri, Apr 17, 3:19 PM |
| F76371424: wikipedia-quote-marna--fiume-(2).png | |
| Fri, Apr 17, 10:11 AM |
| Restricted File | |
| Fri, Apr 17, 10:11 AM |
| F73662645: wikipedia-quote-robert-crumb.png | |
| Mar 25 2026, 12:03 PM |
| F73662651: Screenshot 2026-03-25 at 12.58.28.png | |
| Mar 25 2026, 12:03 PM |
When the dark background is selected, the downloaded PNG preserves the font color, but the background becomes white, making the quoted text invisible.
Share quote dialog example:
When the transparent background is selected, the downloaded PNG doesn't seem to preserve the transparency.
Share quote dialog example:
{F76371302}
Downloaded PNG:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T416432 [Epic] Share Card experiment | |||
| Resolved | BUG REPORT | lwatson | T421134 [Share Highlights] Broken PNG download when the share card's background is dark or transparent |
Change #1273754 had a related patch set uploaded (by LWatson; author: LWatson):
[mediawiki/extensions/ReaderExperiments@master] Share Highlights: fix PNG download
Test wiki created on Patch demo by LWatson-WMF using patch(es) linked to this task:
https://d706b87645.catalyst.wmcloud.org/wiki/Main Page
Test wiki on Patch demo by LWatson-WMF using patch(es) linked to this task was deleted:
Test wiki created on Patch demo by LWatson-WMF using patch(es) linked to this task:
https://fb5eb727ec.catalyst.wmcloud.org/wiki/Main Page
Test wiki on Patch demo by LWatson-WMF using patch(es) linked to this task was deleted:
✅ Tested downloaded PNG on Firefox browser.
✅ Tested the share card via AirDrop and Apple Notes.
Notes:
cc: @JScherer-WMF
Moving back to code review after considering Minerva's night/light modes T423688: [Share Highlights] Light and transparent backgrounds don't display properly in Minerva's dark theme.
Update: In the dialog preview, the dark and light background color options use fixed font and background colors; therefore, the card is consistent between Minerva's night/light mode. Using a fixed font color for the transparent option makes the text invisible over a dark background in the dialog preview; therefore, the transparent option's text color remains responsive to modes. For example, when Minerva's night mode is enabled, the transparent option's font color is white, and when light mode is enabled, the transparent card's font color is black.
Change #1273754 merged by jenkins-bot:
[mediawiki/extensions/ReaderExperiments@master] Share Highlights: fix PNG download
Moved back to "Doing" - next steps per Justin in Slack:
layer a white background behind the transparent card in the preview so that the text colour doesn't change
Change #1276795 had a related patch set uploaded (by LWatson; author: LWatson):
[mediawiki/extensions/ReaderExperiments@master] Share Highlight: remove transparent background color option
Moving to code review for change 1276795. Team discussed removing the transparent option for now and resuming it if time permits before the experiment launch date.
Change #1276795 merged by jenkins-bot:
[mediawiki/extensions/ReaderExperiments@master] Share Highlight: remove transparent background color option
Moving to sign off and skipping QA because we decided to remove background color customization T424424: Share Highlight: remove card customization (background color options). The experiment will ship the average background color. Transparent option removal found in this change: https://gerrit.wikimedia.org/r/1276795