Page MenuHomePhabricator

Remove OTRS from global block list
Closed, ResolvedPublic

Description

Author: Tiptoety

Description:
For some reason OTRS-wiki is affected by global blocks. Given that the wiki is private there is no need for global blocks. Please remove OTRS-wiki from the list of wiki's affected by such blocks.


Version: unspecified
Severity: normal

Details

Reference
bz40122

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:44 AM
bzimport set Reference to bz40122.
bzimport added a subscriber: Unknown Object (MLST).

Maybe I'm missing something here, but why would you want globally blocked users to have access to OTRS-wiki?

Some users who have access to the otrs wiki are obviously caught in global blocks.

Thehelpfulonewiki wrote:

Users aren't globally blocked Pine, they are globally locked.

Global blocking is done on IPs, please see https://meta.wikimedia.org/wiki/Global_blocks for more information.

Tiptoety wrote:

(In reply to comment #1)

Maybe I'm missing something here, but why would you want globally blocked users
to have access to OTRS-wiki?

Global *blocks*, not global locks. Global blocks affect IPs. We recently had an issue where a legit established OTRS user was attempting to edit the wiki, but was doing so through a globally blocked IP and therefore could not. While giving them IPBE solves the issue, there is no reason that we should even have the issue in the first place give everyone on OTRS-wiki is trusted.

What concerns me is the thought that when true global blocks of usernames are implemented, then a user who is globally blocked would still have access to OTRS-wiki if this wiki gets an exception. I don't think we'd want a user who has been globally blocked to continue to have access to OTRS-wiki.

Tiptoety wrote:

Try reading the responses again before saying the same thing twice.

I would think that IPBE would be the appropriate thing to do.

/facepalm IPBE shouldnt be needed as global IP blocks shouldn't effect this wiki

I withdraw my objection *for now* since global blocks for users are still hypothetical and making someone IPBE exposes their IP.

I'm thinking this should be changed for all fishbowls and privates. Looked at the list of all such current wikis and saw no obvious issues. The one caveat is that this would also (I think?) effect whether or not blocked IPs could trigger password reset emails.

I've sent a proposed change: I13b3be3aa77b58ef072

[ Raising priority to high, as it's a trivial issue to fix and blocks the regular work from one legit user on this wiki. ]

(In reply to comment #13)

blocks the
regular work from one legit user on this wiki.

I don't think so? As far as I know this has been addressed with IPBE for any currently affected users.

Deployed live at Tue, 18 Sep 2012 14:08:38 +0000

Thanks for the patch!