🚧 Wikibase secondary CI failing - LinkRenderer::makeRedirectHeader() argument #1 should be MediaWiki\Language\Language
Closed, ResolvedPublic
Actions

Assigned To

mahmoud.abdelsattar.wmde

Authored By

	ArthurTaylor
	Mar 25 2026, 1:02 PM

Description

Seeing failures in secondary CI for some jobs:

https://github.com/wikimedia/mediawiki-extensions-Wikibase/actions/runs/23540655999/job/68527089530

1) Wikibase\Repo\Tests\Content\ItemHandlerTest::testGetParserOutput_redirect
TypeError: MediaWiki\Linker\LinkRenderer::makeRedirectHeader(): Argument #1 ($lang) must be of type MediaWiki\Language\Language, MediaWiki\StubObject\StubUserLang given, called in /home/runner/work/mediawiki-extensions-Wikibase/mediawiki/extensions/Wikibase/repo/includes/Content/EntityHandler.php on line 829

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Unstub langage object in EntityHandler	mediawiki/extensions/Wikibase	master	+2 -0

Customize query in gerrit

Event Timeline

ArthurTaylor created this task.Mar 25 2026, 1:02 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2026, 1:02 PM

ArthurTaylor renamed this task from Wikibase secondary CI failing - LinkRenderer::makeRedirectHeader() argument #1 should be MediaWiki\Language\Language to 🚧 Wikibase secondary CI failing - LinkRenderer::makeRedirectHeader() argument #1 should be MediaWiki\Language\Language.Mar 25 2026, 1:03 PM

ArthurTaylor moved this task from Incoming to The Backlog on the Wikidata-Omega board.

I guess we can make EntityHandler::getPageViewLanguage() return StubUserLang::unstub( $wgLang )? (Or StubObject::unstub( $wgLang ); core seems to do both.) Or try to figure out what’s going on in more detail…

WMDE-leszek subscribed.Mar 26 2026, 7:31 AM

ArthurTaylor claimed this task.Mar 26 2026, 7:49 AM

ArthurTaylor moved this task from The Backlog to The Board on the Wikidata-Omega board.

ArthurTaylor edited projects, added Wikidata-Omega (The Board); removed Wikidata-Omega.

ArthurTaylor moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.

@Lucas_Werkmeister_WMDE That change definitely fixes the issue.

I tried running the tests locally (in docker with a fresh mediawiki) and was able to reproduce the issue that we were seeing in Secondary CI. I tried rolling back versions of Wikibase, Mediawiki and cldr / Scribunto, but nothing seemed to make the error go away. Also downgrading the libraries when I rolled back mediawiki didn't seem to make a difference. So I'm a bit stumped as to what the issue might be, but maybe that's not so important.

Change #1261358 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Unstub langage object in EntityHandler

https://gerrit.wikimedia.org/r/1261358

gerritbot added a project: Patch-For-Review.Mar 26 2026, 9:12 AM

ArthurTaylor removed ArthurTaylor as the assignee of this task.Mar 26 2026, 9:16 AM

ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.

ArthurTaylor claimed this task.Mar 26 2026, 9:18 AM

ArthurTaylor moved this task from Ready for Peer Review to In Development on the Wikidata-Omega (The Board) board.

ArthurTaylor removed ArthurTaylor as the assignee of this task.Mar 26 2026, 9:40 AM

ArthurTaylor moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.

AudreyPenven_WMDE claimed this task.Mar 26 2026, 5:23 PM

AudreyPenven_WMDE removed AudreyPenven_WMDE as the assignee of this task.