[Refactor] Implement a method to find Citation commands from InternalItems
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	WMDE-Fisch
	Mar 25 2026, 3:55 PM

Description

Context

We need to be able to find the right citation command for opening the CitationDialog when editing sub-refs and their main content. Currently the main node is used to achieve that. With the main node gone in some cases, we need to find a way to connect the existing commands with the InternalItem of the main content.

Background

In ve.ui.MWReference.init.js the commands will be build add-hoc for the configured citation tool templates. The name of the template that should be loaded is weird here and used to setup the right parameters when opening the CitationDialog.

Solution

We could try to identify the existing tools and iterate over the template names to get to the fitting command for a template inside of an InterntalItem.

Next steps

Add a method to the helper in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/1261517 that can iterate over the tools and checks of one of the templates configured fits with content. Then use the name to find the command.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
VE: Allow getting the command from a ref's InternalItem	mediawiki/extensions/Cite	master	+14 -10
VE: Extract method to check for Citation template content	mediawiki/extensions/Cite	master	+44 -31
VE: Add more documentation to CitationTools code	mediawiki/extensions/Cite	master	+27 -20
VE: Add helper methods to create Citation tool commands	mediawiki/extensions/Cite	master	+101 -43
Move global ve.ui.mwCitationTools into new file	mediawiki/extensions/Cite	master	+6 -5
VE: Move init code for the CitationTools to own file	mediawiki/extensions/Cite	master	+114 -102

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Duplicate	None	T411856 [Epic] Avoid unintended content loss due the usage of synthetic ldr's
In Progress	None	T397501 [Epic] Fix issues with {{reflist}} or missing references lists and main+details sub-references
Resolved	None	T415884 [Refactor] Replace MWReferenceNode.mainRefKey with an index to the main ref InternalItemNode
Resolved	None	T420971 [Refactor] Allow editing main content in the CitationDialog of a sub-ref node without relying on a main node
Resolved	None	T421248 [Refactor] Implement a method to find Citation commands from InternalItems

Event Timeline

WMDE-Fisch created this task.Mar 25 2026, 3:55 PM

WMDE-Fisch claimed this task.

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2026-03-17-all-of-the-beans board.

WMDE-Fisch moved this task from Incoming to Dev-Work on the Cite (Sub-referencing) board.

Change #1260746 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Move init code for the CitationTools to own file

https://gerrit.wikimedia.org/r/1260746

gerritbot added a project: Patch-For-Review.Mar 25 2026, 4:13 PM

Change #1260746 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] VE: Move init code for the CitationTools to own file

https://gerrit.wikimedia.org/r/1260746

Maintenance_bot removed a project: Patch-For-Review.Mar 26 2026, 12:30 PM

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.22; 2026-03-31).Mar 26 2026, 1:00 PM

Change #1261443 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Move global ve.ui.mwCitationTools into new file

https://gerrit.wikimedia.org/r/1261443

gerritbot added a project: Patch-For-Review.Mar 26 2026, 1:17 PM

Change #1261446 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Add helper methods to create Citation tool commands

https://gerrit.wikimedia.org/r/1261446

Change #1261517 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Extract method to check for Citation template to helper class

https://gerrit.wikimedia.org/r/1261517

WMDE-Fisch removed WMDE-Fisch as the assignee of this task.Mar 26 2026, 6:26 PM

WMDE-Fisch updated the task description. (Show Details)

WMDE-Fisch moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2026-03-17-all-of-the-beans board.

MareikeHeuerWMDE moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2026-03-17-all-of-the-beans board.Mar 30 2026, 8:00 AM

WMDE-Fisch claimed this task.Apr 2 2026, 9:40 AM

Change #1266943 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Add nodeToEdit support for CitationDialog

https://gerrit.wikimedia.org/r/1266943

Change #1266951 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Add more documentation to Citation Tool code

https://gerrit.wikimedia.org/r/1266951

Change #1261443 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Move global ve.ui.mwCitationTools into new file

https://gerrit.wikimedia.org/r/1261443

ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.23; 2026-04-07); removed MW-1.46-notes (1.46.0-wmf.22; 2026-03-31).Apr 2 2026, 10:00 AM

Change #1266977 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Allow getting a command from an InternalItem

https://gerrit.wikimedia.org/r/1266977

Change #1261446 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] VE: Add helper methods to create Citation tool commands

https://gerrit.wikimedia.org/r/1261446

ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.24; 2026-04-14); removed MW-1.46-notes (1.46.0-wmf.23; 2026-04-07).Apr 8 2026, 12:00 PM

Change #1266951 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] VE: Add more documentation to CitationTools code

https://gerrit.wikimedia.org/r/1266951

Change #1261517 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] VE: Extract method to check for Citation template content

https://gerrit.wikimedia.org/r/1261517

Change #1266977 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] VE: Allow getting the command from a ref's InternalItem

https://gerrit.wikimedia.org/r/1266977

WMDE-Fisch moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2026-03-17-all-of-the-beans board.Apr 9 2026, 2:22 PM

WMDE-Fisch removed WMDE-Fisch as the assignee of this task.Apr 9 2026, 3:20 PM

thiemowmde closed this task as Resolved.Apr 14 2026, 8:20 AM

[Refactor] Implement a method to find Citation commands from InternalItemsClosed, ResolvedPublicActions