Page MenuHomePhabricator

AbuseFilter CI is broken due to unconditional module ext.visualEditor.mwcore from CodeMirror
Closed, ResolvedPublic

Description

AbuseFilter extensions CI failure for CodeMirror resourceloader modules

AbuseFilter CI is running without the optional dependency VisualEditor and fails.
CodeMirror CI seems to run with VisualEditor

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php83/57102/console

20:12:43 There was 1 failure:
20:12:43 
20:12:43 1) ResourcesTest::testValidDependencies
20:12:43 Dependencies that do not exist
20:12:43 Failed asserting that two arrays are equal.
20:12:43 --- Expected
20:12:43 +++ Actual
20:12:43 @@ @@
20:12:43  Array (
20:12:43      'ext.CodeMirror.visualEditor' => Array (
20:12:43 +        0 => 'ext.visualEditor.mwcore'
20:12:43 +        1 => 'ext.visualEditor.mwmeta'
20:12:43      )
20:12:43      'ext.CodeMirror.v6.visualEditor' => Array (
20:12:43 +        0 => 'ext.visualEditor.mwcore'
20:12:43 +        1 => 'ext.visualEditor.mwmeta'
20:12:43      )
20:12:43  )

Event Timeline

Change #1260796 had a related patch set uploaded (by Reedy; author: Reedy):

[integration/config@master] Revert "Zuul: [mediawiki/extensions/AbuseFilter] Add dependency on CodeMirror"

https://gerrit.wikimedia.org/r/1260796

Change #1260796 merged by jenkins-bot:

[integration/config@master] Revert "Zuul: [mediawiki/extensions/AbuseFilter] Add dependency on CodeMirror"

https://gerrit.wikimedia.org/r/1260796

Reedy claimed this task.