Page MenuHomePhabricator
Create Task
Maniphest T421352

User requirements conditions hooks: set the condition type as string|int
Closed, ResolvedPublic
Actions

Description

Until MediaWiki 1.45, AutopromoteConditionHook accepted any datatype as the condition type and had a doc comment saying that it should be a string. I practice, strings and ints were passed. Given that we'd like to actually specify type hints on UserRequirementsConditionHook and UserRequirementsConditionDisplayHook, the practice should be reconciled into one of two options:

  1. Specify string|int as parameter type in the hooks. Extensions would require no changes to adapt.
  2. Convert condition type to string and then have only string as accepted parameter type. Extensions would need to adjust the type of the value they compare to.

The first option will sanction the current state of passing strings or ints to the hooks, unlike specified in the documentation for AutopromoteConditionHook. This will be the option to go.

Acceptance criteria

  • UserRequirementsConditionHook and UserRequirementsConditionDisplayHook define the parameters as string|int
  • FlaggedRevs is updated to have string|int type specified
  • CentralAuth is updated to have string|int type specified
  • OATHAuth is updated to have string|int type specified
  • TorBlock is updated to have string|int type specified

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add type hint to user requirements conditions hooksmediawiki/extensions/FlaggedRevsmaster+2 -2
Add type hint to user requirements conditions hooksmediawiki/extensions/CentralAuthmaster+2 -2
Add type hint to UserRequirementsCondition hookmediawiki/extensions/OATHAuthmaster+1 -1
Add type hint to UserRequirementsCondition hookmediawiki/extensions/TorBlockmaster+1 -1
Prepare user requirements condition hooks for string-only $typemediawiki/extensions/CentralAuthmaster+3 -3
Prepare user requirements condition hooks for string-only $typemediawiki/extensions/FlaggedRevsmaster+16 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

mszwarc created this task.Mar 26 2026, 11:34 AM
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptMar 26 2026, 11:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
mszwarc moved this task from Backlog to Ready on the Product Safety and Integrity (Sprint Forsythia (Mar 23 - Apr 10))) board.Mar 26 2026, 11:34 AM
mszwarc moved this task from Ready to In progress on the Product Safety and Integrity (Sprint Forsythia (Mar 23 - Apr 10))) board.Mar 26 2026, 11:55 AM
gerritbot added a comment.Mar 26 2026, 12:23 PM

Change #1261414 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/FlaggedRevs@master] Prepare user requirements condition hooks for string-only $type

https://gerrit.wikimedia.org/r/1261414

gerritbot added a project: Patch-For-Review.Mar 26 2026, 12:23 PM

Change #1261415 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CentralAuth@master] Prepare user requirements condition hooks for string-only $type

https://gerrit.wikimedia.org/r/1261415

mszwarc moved this task from In progress to Needs review on the Product Safety and Integrity (Sprint Forsythia (Mar 23 - Apr 10))) board.Mar 26 2026, 2:20 PM
gerritbot added a comment.Mar 27 2026, 11:16 AM

Change #1261414 abandoned by Mszwarc:

[mediawiki/extensions/FlaggedRevs@master] Prepare user requirements condition hooks for string-only $type

Reason:

string|int will be kept as type

https://gerrit.wikimedia.org/r/1261414

gerritbot added a comment.Mar 27 2026, 11:16 AM

Change #1261415 abandoned by Mszwarc:

[mediawiki/extensions/CentralAuth@master] Prepare user requirements condition hooks for string-only $type

Reason:

string|int will be kept as type

https://gerrit.wikimedia.org/r/1261415

mszwarc renamed this task from User requirements conditions hooks: pass the condition type as string only to User requirements conditions hooks: set the condition type as string|int.Mar 27 2026, 11:20 AM
mszwarc updated the task description. (Show Details)
Maintenance_bot removed a project: Patch-For-Review.Mar 27 2026, 11:31 AM
mszwarc moved this task from Needs review to Backlog on the Product Safety and Integrity (Sprint Forsythia (Mar 23 - Apr 10))) board.Mar 30 2026, 2:05 PM
matmarex moved this task from Inbox, needs triage to Radar on the MediaWiki-Platform-Team board.Mar 30 2026, 2:52 PM
matmarex edited projects, added MediaWiki-Platform-Team (Radar); removed MediaWiki-Platform-Team.
matmarex added a subtask: T421126: User requirements conditions: Ensure that condition type is string or int.Mar 30 2026, 3:50 PM
matmarex subscribed.
mszwarc moved this task from Backlog to In progress on the Product Safety and Integrity (Sprint Forsythia (Mar 23 - Apr 10))) board.Mar 31 2026, 11:45 AM
gerritbot added a comment.Apr 1 2026, 10:29 AM

Change #1266206 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CentralAuth@master] Add type hint to user requirements conditions hooks

https://gerrit.wikimedia.org/r/1266206

gerritbot added a project: Patch-For-Review.Apr 1 2026, 10:29 AM

Change #1266207 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/FlaggedRevs@master] Add type hint to user requirements conditions hooks

https://gerrit.wikimedia.org/r/1266207

gerritbot added a comment.Apr 1 2026, 10:32 AM

Change #1266208 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/OATHAuth@master] Add type hint to UserRequirementsCondition hook

https://gerrit.wikimedia.org/r/1266208

gerritbot added a comment.Apr 1 2026, 10:33 AM

Change #1266209 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/TorBlock@master] Add type hint to UserRequirementsCondition hook

https://gerrit.wikimedia.org/r/1266209

mszwarc moved this task from In progress to Needs review on the Product Safety and Integrity (Sprint Forsythia (Mar 23 - Apr 10))) board.Apr 1 2026, 11:34 AM
gerritbot added a comment.Apr 8 2026, 2:07 PM

Change #1266209 merged by jenkins-bot:

[mediawiki/extensions/TorBlock@master] Add type hint to UserRequirementsCondition hook

https://gerrit.wikimedia.org/r/1266209

gerritbot added a comment.Apr 8 2026, 2:07 PM

Change #1266208 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] Add type hint to UserRequirementsCondition hook

https://gerrit.wikimedia.org/r/1266208

gerritbot added a comment.Apr 8 2026, 2:09 PM

Change #1266207 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Add type hint to user requirements conditions hooks

https://gerrit.wikimedia.org/r/1266207

gerritbot added a comment.Apr 8 2026, 2:10 PM

Change #1266206 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Add type hint to user requirements conditions hooks

https://gerrit.wikimedia.org/r/1266206

Maintenance_bot removed a project: Patch-For-Review.Apr 8 2026, 2:32 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.24; 2026-04-14).Apr 8 2026, 3:00 PM
mszwarc closed this task as Resolved.Apr 9 2026, 7:58 AM
mszwarc moved this task from Needs review to Done on the Product Safety and Integrity (Sprint Forsythia (Mar 23 - Apr 10))) board.
mszwarc updated the task description. (Show Details)
mszwarc closed subtask T421126: User requirements conditions: Ensure that condition type is string or int as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits