Page MenuHomePhabricator
Create Task
Maniphest T421659

Extension:CloseWikis phpunit tests fail due to missing database
Open, Needs TriagePublic
Actions

Description

2:26:17 Creating tables for enabled extensions... Wikimedia\Rdbms\DBQueryError from line 1230 of /workspace/src/includes/libs/Rdbms/Database/Database.php: Error 1146: Table 'wikidb.closedwikis' doesn't exist
02:26:17 Function: MediaWiki\Installer\DatabaseUpdater::dropIndex
02:26:17 Query: SHOW INDEX FROM `closedwikis`
02:26:17 
02:26:17 #0 /workspace/src/includes/libs/Rdbms/Database/Database.php(1214): Wikimedia\Rdbms\Database->getQueryException()
02:26:17 #1 /workspace/src/includes/libs/Rdbms/Database/Database.php(1188): Wikimedia\Rdbms\Database->getQueryExceptionAndLog()
02:26:17 #2 /workspace/src/includes/libs/Rdbms/Database/Database.php(644): Wikimedia\Rdbms\Database->reportQueryError()
02:26:17 #3 /workspace/src/includes/libs/Rdbms/Database/DatabaseMySQL.php(352): Wikimedia\Rdbms\Database->query()
02:26:17 #4 /workspace/src/includes/libs/Rdbms/Database/Database.php(1478): Wikimedia\Rdbms\DatabaseMySQL->indexInfo()
02:26:17 #5 /workspace/src/includes/Installer/DatabaseUpdater.php(979): Wikimedia\Rdbms\Database->indexExists()
02:26:17 #6 /workspace/src/includes/Installer/DatabaseUpdater.php(586): MediaWiki\Installer\DatabaseUpdater->dropIndex()
02:26:17 #7 /workspace/src/includes/Installer/DatabaseUpdater.php(543): MediaWiki\Installer\DatabaseUpdater->runUpdates()
02:26:17 #8 /workspace/src/includes/Installer/Task/ExtensionTablesTask.php(45): MediaWiki\Installer\DatabaseUpdater->doUpdates()
02:26:17 #9 /workspace/src/includes/Installer/Task/TaskRunner.php(155): MediaWiki\Installer\Task\ExtensionTablesTask->execute()
02:26:17 #10 /workspace/src/includes/Installer/Task/TaskRunner.php(52): MediaWiki\Installer\Task\TaskRunner->runTask()
02:26:17 #11 /workspace/src/includes/Installer/Installer.php(1467): MediaWiki\Installer\Task\TaskRunner->execute()
02:26:17 #12 /workspace/src/includes/Installer/CliInstaller.php(212): MediaWiki\Installer\Installer->performInstallation()
02:26:17 #13 /workspace/src/maintenance/install.php(206): MediaWiki\Installer\CliInstaller->execute()
02:26:17 #14 /workspace/src/maintenance/includes/MaintenanceRunner.php(694): CommandLineInstaller->execute()
02:26:17 #15 /workspace/src/maintenance/doMaintenance.php(88): MediaWiki\Maintenance\MaintenanceRunner->run()
02:26:17 #16 /workspace/src/maintenance/install.php(275): require_once('...')
02:26:17 #17 {main}

See also T157815.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use a virtual domain instead of a config variable for the central DBmediawiki/extensions/CloseWikismaster+24 -29
Installer: Skip dropIndex() when table does not existsmediawiki/coreREL1_44+12 -0
Installer: Skip dropIndex() when table does not existsmediawiki/coreREL1_43+12 -0
Installer: Skip dropIndex() when table does not existsmediawiki/coreREL1_45+12 -0
Installer: Skip dropIndex() when table does not existsmediawiki/coremaster+12 -0
Customize query in gerrit

Related Objects

Event Timeline

MGChecker created this task.Mar 30 2026, 12:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 30 2026, 12:34 AM
MGChecker renamed this task from Extension:CloseWikis phpunit tests fail due to missing databas to Extension:CloseWikis phpunit tests fail due to missing database.Mar 31 2026, 12:42 PM
gerritbot added a comment.Mar 31 2026, 2:20 PM

Change #1265428 had a related patch set uploaded (by SomeRandomDeveloper; author: SomeRandomDeveloper):

[mediawiki/extensions/CloseWikis@master] Use a virtual domain instead of a config variable for the central DB

https://gerrit.wikimedia.org/r/1265428

gerritbot added a project: Patch-For-Review.Mar 31 2026, 2:20 PM
SomeRandomDeveloper claimed this task.Mar 31 2026, 2:22 PM
SomeRandomDeveloper subscribed.

I'm not sure what the cause of the failures is, but it's easier to just use a virtual domain (which allows us to create the table through update.php) and remove the unit test hacks.

Bugreporter2 awarded a token.Mar 31 2026, 2:54 PM
gerritbot added a comment.Apr 7 2026, 5:36 PM

Change #1268610 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Installer: Skip dropIndex() when table does not exists

https://gerrit.wikimedia.org/r/1268610

gerritbot added a comment.Apr 7 2026, 8:04 PM

Change #1268610 merged by jenkins-bot:

[mediawiki/core@master] Installer: Skip dropIndex() when table does not exists

https://gerrit.wikimedia.org/r/1268610

gerritbot added a comment.Apr 7 2026, 8:32 PM

Change #1268657 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_45] Installer: Skip dropIndex() when table does not exists

https://gerrit.wikimedia.org/r/1268657

gerritbot added a comment.Apr 7 2026, 8:39 PM

Change #1268658 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_44] Installer: Skip dropIndex() when table does not exists

https://gerrit.wikimedia.org/r/1268658

gerritbot added a comment.Apr 7 2026, 8:39 PM

Change #1268659 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@REL1_43] Installer: Skip dropIndex() when table does not exists

https://gerrit.wikimedia.org/r/1268659

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.24; 2026-04-14).Apr 7 2026, 9:00 PM
gerritbot added a comment.Apr 7 2026, 9:15 PM

Change #1268659 merged by jenkins-bot:

[mediawiki/core@REL1_43] Installer: Skip dropIndex() when table does not exists

https://gerrit.wikimedia.org/r/1268659

gerritbot added a comment.Apr 7 2026, 9:16 PM

Change #1268657 merged by jenkins-bot:

[mediawiki/core@REL1_45] Installer: Skip dropIndex() when table does not exists

https://gerrit.wikimedia.org/r/1268657

gerritbot added a comment.Apr 7 2026, 9:17 PM

Change #1268658 merged by jenkins-bot:

[mediawiki/core@REL1_44] Installer: Skip dropIndex() when table does not exists

https://gerrit.wikimedia.org/r/1268658

ReleaseTaggerBot added projects: MW-1.43-notes, MW-1.45-notes, MW-1.44-notes.Apr 7 2026, 10:00 PM
SomeRandomDeveloper added a project: User-SomeRandomDeveloper.Wed, May 20, 11:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits