Page MenuHomePhabricator
Create Task
Maniphest T421960

Donor Portal - investigation required: recurring upgrade email activity tracking parameter issue
Open, MediumPublic
Actions

Description

The recurring upgrade email is currently in use by both recurring upgrade campaign donation form and the donor portal.

Activity tracking for this email is set to "From Donor Portal = yes".

Emails triggered by the recurring upgrade campaign donation form should read "From Donor Portal = no"

Analytics reports this parameter has been reported in thousands of activities over the past few weeks, more than the donor portal could have generated. Please investigate to see if this parameter needs to be updated via the recurring upgrade campaign donation form.

image (3).png (286×1 px, 28 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
RecurUpgrade gets its own source_typemediawiki/extensions/DonationInterfacemaster+2 -0
Customize query in gerrit

Event Timeline

KHill-WMF created this task.Tue, Mar 31, 8:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Mar 31, 8:09 PM
XenoRyet moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Tue, Apr 7, 7:29 PM
XenoRyet added a project: GNU England Shaker dresser.Tue, Apr 7, 7:34 PM
Ejegg subscribed.Tue, Apr 7, 9:03 PM

Easiest fix is just to change the source_type for the recurring upgrade page

gerritbot added a comment.Tue, Apr 7, 9:08 PM

Change #1268665 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/DonationInterface@master] RecurUpgrade gets its own source_type

https://gerrit.wikimedia.org/r/1268665

gerritbot added a project: Patch-For-Review.Tue, Apr 7, 9:08 PM
Ejegg triaged this task as Medium priority.Tue, Apr 7, 9:11 PM
Ejegg moved this task from Backlog to Ready for Review on the GNU England Shaker dresser board.
gerritbot added a comment.Tue, Apr 7, 10:20 PM

Change #1268665 merged by jenkins-bot:

[mediawiki/extensions/DonationInterface@master] RecurUpgrade gets its own source_type

https://gerrit.wikimedia.org/r/1268665

Maintenance_bot removed a project: Patch-For-Review.Tue, Apr 7, 10:31 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.24; 2026-04-14).Tue, Apr 7, 11:00 PM
Ejegg moved this task from Backlog to Done on the FR-Donor-portal board.Wed, Apr 8, 1:20 AM
Ejegg moved this task from Ready for Review to Done on the GNU England Shaker dresser board.

OK, just deployed something that I think will stop the recurring upgrade page from setting 'yes' here.

Ejegg claimed this task.Wed, Apr 8, 1:22 AM
CHudson-WMF added a comment.Wed, Apr 8, 6:33 PM

Thanks, @Ejegg--would you be able to set the prior activities that were incorrectly set to Is from Donor Portal to no for those that were incorrectly classified as yes? I've re-classified these activities in the data pipelines, but it would be good to be consistent between Metabase and Civi, if possible.

Ejegg added a comment.Wed, Apr 8, 6:54 PM

@CHudson-WMF is it OK to just set all the existing ones to 'no' since any donor portal ones would just be from our internal testing?

Ejegg added a comment.Wed, Apr 8, 8:33 PM

@CHudson-WMF I set all the ones with tracking medium = email to 'no'. Do the numbers look good now?

CHudson-WMF added a comment.Wed, Apr 8, 9:07 PM

Yep, these look good 👍

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits