Page MenuHomePhabricator
Create Task
Maniphest T421987

[Refactor] Consolidate numbering logic so that footnote markers and reference list use the same algorithm
Closed, ResolvedPublic
Actions

Description

In T415525: [Refactor] Show main content in the ReferencesList of a sub-ref node without relying on a main node we added a new code path for rendering a ve.ce.MWReferencesList, but this now becomes totally independent of the code in ve.dm.MWGroupReferences which is used to number footnote markers. This is a fragile situation, and we would like to patch it up by doing the following:

  • Rewrite MWGroupReferences to do numbering with the same algorithm as the reference list, which was introduced into MWDataTransitionHelper.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Drop two more deprecated ve.dm.MWGroupReferences methodsmediawiki/extensions/Citemaster+4 -41
Move single-use ve.dm.MWDocumentReferences method to be privatemediawiki/extensions/Citemaster+31 -22
Inline now unused ve.dm.MWGroupReferences.getSubrefsmediawiki/extensions/Citemaster+8 -31
Drop unused code from intermediate ve.dm.MWGroupReferencesmediawiki/extensions/Citemaster+1 -103
Replace MWGroupReferences innards with MWDataTransitionHelpermediawiki/extensions/Citemaster+43 -101
Customize query in gerrit

Related Objects
Search...

Event Timeline

awight created this task.Apr 1 2026, 8:43 AM
lilients_WMDE moved this task from Incoming to NOW on the Cite (Sub-referencing) board.Apr 8 2026, 9:34 AM
awight claimed this task.Apr 13 2026, 7:33 AM
awight moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2026-03-17-all-of-the-beans board.
gerritbot added a comment.Apr 13 2026, 1:41 PM

Change #1270446 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] [WIP] Replace MWGroupReferences innards with MWDataTransitionHelper

https://gerrit.wikimedia.org/r/1270446

gerritbot added a project: Patch-For-Review.Apr 13 2026, 1:41 PM
WMDE-Fisch added a project: WMDE-TechWish-Sprint-2026-04-14-Greeny-Zucchini.Apr 14 2026, 9:16 AM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2026-04-14-Greeny-Zucchini board.
awight removed awight as the assignee of this task.Apr 14 2026, 1:03 PM
awight moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2026-04-14-Greeny-Zucchini board.
awight moved this task from Doing to Demo on the WMDE-TechWish-Sprint-2026-03-17-all-of-the-beans board.Apr 17 2026, 8:22 AM
gerritbot added a comment.Apr 17 2026, 8:45 AM

Change #1270446 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Replace MWGroupReferences innards with MWDataTransitionHelper

https://gerrit.wikimedia.org/r/1270446

MareikeHeuerWMDE moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2026-04-14-Greeny-Zucchini board.Apr 17 2026, 9:00 AM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.26; 2026-04-28).Apr 17 2026, 9:01 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 17 2026, 9:31 AM
gerritbot added a comment.Apr 27 2026, 8:14 AM

Change #1277304 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Drop unused code from intermediate ve.dm.MWGroupReferences

https://gerrit.wikimedia.org/r/1277304

gerritbot added a project: Patch-For-Review.Apr 27 2026, 8:14 AM
gerritbot added a comment.Apr 27 2026, 8:41 AM

Change #1277427 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Inline now unused ve.dm.MWGroupReferences.getSubrefs

https://gerrit.wikimedia.org/r/1277427

gerritbot added a comment.Apr 27 2026, 8:51 AM

Change #1277428 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Move single-use ve.dm.MWDocumentReferences method to be private

https://gerrit.wikimedia.org/r/1277428

gerritbot added a comment.Apr 27 2026, 12:06 PM

Change #1277304 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Drop unused code from intermediate ve.dm.MWGroupReferences

https://gerrit.wikimedia.org/r/1277304

gerritbot added a comment.Apr 27 2026, 1:33 PM

Change #1277427 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Inline now unused ve.dm.MWGroupReferences.getSubrefs

https://gerrit.wikimedia.org/r/1277427

Tobi_WMDE_SW closed this task as Resolved.Apr 29 2026, 11:30 AM
Tobi_WMDE_SW claimed this task.
Tobi_WMDE_SW removed Tobi_WMDE_SW as the assignee of this task.Apr 29 2026, 12:33 PM
Tobi_WMDE_SW subscribed.
gerritbot added a comment.Mon, May 11, 4:05 PM

Change #1277428 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Move single-use ve.dm.MWDocumentReferences method to be private

https://gerrit.wikimedia.org/r/1277428

Maintenance_bot removed a project: Patch-For-Review.Mon, May 11, 4:31 PM
gerritbot added a comment.Tue, May 12, 7:43 AM

Change #1286173 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Drop two more deprecated ve.dm.MWGroupReferences methods

https://gerrit.wikimedia.org/r/1286173

gerritbot added a project: Patch-For-Review.Tue, May 12, 7:43 AM
gerritbot added a comment.Wed, May 13, 8:49 AM

Change #1286173 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Drop two more deprecated ve.dm.MWGroupReferences methods

https://gerrit.wikimedia.org/r/1286173

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).Wed, May 13, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Wed, May 13, 9:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits