Page MenuHomePhabricator
Create Task
Maniphest T422137

🧄 Use ItemWbSearchEntitiesController in repo/WikibaseRepo.controllers.php
Open, Needs TriagePublic
Actions

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Search: Enable ItemWbSearchEntitiesControllermediawiki/extensions/Wikibasemaster+36 -64
Adjust SearchEntitiesIntegrationTest to new WbSearchEntitiesControllermediawiki/extensions/WikibaseCirrusSearchmaster+42 -25
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Apr 2 2026, 10:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2026, 10:33 AM
Ifrahkhanyaree_WMDE edited projects, added Wikibase Reuse Team (Sprint 67); removed Wikibase Reuse Team (Sprint 66).Wed, Apr 15, 9:28 AM
Silvan_WMDE claimed this task.Wed, Apr 22, 2:10 PM
Silvan_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 67) board.
gerritbot added a comment.Wed, Apr 22, 3:43 PM

Change #1276405 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] Search: Enable ItemWbSearchEntitiesController

https://gerrit.wikimedia.org/r/1276405

gerritbot added a project: Patch-For-Review.Wed, Apr 22, 3:43 PM
gerritbot added a comment.Fri, Apr 24, 1:20 PM

Change #1277094 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/WikibaseCirrusSearch@master] Adjust SearchEntitiesIntegrationTest to new WbSearchEntitiesController

https://gerrit.wikimedia.org/r/1277094

Ifrahkhanyaree_WMDE edited projects, added Wikibase Reuse Team (Sprint 68); removed Wikibase Reuse Team (Sprint 67).Mon, Apr 27, 10:16 AM
Ifrahkhanyaree_WMDE moved this task from To Do to Doing on the Wikibase Reuse Team (Sprint 68) board.
Silvan_WMDE added a comment.Tue, Apr 28, 11:40 AM

Using ItemWbSearchEntitiesController unconditionally here, would break wbsearchentities for Wikibase instances without ElasticSearch, which is probably not intended. The proposed patch keeps the fallback controller if CirrusSearch is not enabled - let's discuss what is the best solution.

Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Reuse Team (Sprint 68) board.Tue, Apr 28, 11:40 AM
gerritbot added a comment.Wed, May 6, 7:56 AM

Change #1277094 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Adjust SearchEntitiesIntegrationTest to new WbSearchEntitiesController

https://gerrit.wikimedia.org/r/1277094

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.2; 2026-05-12).Wed, May 6, 8:00 AM
gerritbot added a comment.Wed, May 6, 8:13 AM

Change #1276405 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Search: Enable ItemWbSearchEntitiesController

https://gerrit.wikimedia.org/r/1276405

Maintenance_bot removed a project: Patch-For-Review.Wed, May 6, 8:31 AM
Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Reuse Team (Sprint 68) board.Wed, May 6, 8:58 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits