Page MenuHomePhabricator

Reflect the group restrictions on Special:GlobalUserRights
Closed, ResolvedPublic

Description

Similarly to its local counterpart, Special:GlobalGroupRights should be aware of restricted groups.

Acceptance criteria

  • If a group is restricted and user cannot be added to it, the checkbox is disabled and an annotation is shown
  • If a group is restricted and uses private conditions, an annotation is shown and conditions are evaluated on saving
  • If performer evaluates a private condition on saving, a relevant hook is called, similarly to Special:UserRights
  • If saving groups fails, an error is displayed, outlining why the groups weren't saved

Event Timeline

Change #1268532 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/core@master] Extract base class from UserGroupAssignmentService

https://gerrit.wikimedia.org/r/1268532

Change #1268533 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/core@master] Move formatInvalidGroupsStatus to UserGroupsSpecialPage

https://gerrit.wikimedia.org/r/1268533

Change #1268536 had a related patch set uploaded (by Mszwarc; author: Mszwarc):

[mediawiki/extensions/CentralAuth@master] Reuse core's methods for validating and logging restricted groups

https://gerrit.wikimedia.org/r/1268536

Change #1268532 merged by jenkins-bot:

[mediawiki/core@master] Extract base class from UserGroupAssignmentService

https://gerrit.wikimedia.org/r/1268532

Change #1268533 merged by jenkins-bot:

[mediawiki/core@master] Move formatInvalidGroupsStatus to UserGroupsSpecialPage

https://gerrit.wikimedia.org/r/1268533

Change #1268536 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Reuse core's methods for validating and logging restricted groups

https://gerrit.wikimedia.org/r/1268536