Page MenuHomePhabricator
Create Task
Maniphest T422143

Suggestion mode showing for all users
Closed, ResolvedPublic
Actions

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fix suggestion mode availability checkEsandersmediawiki/extensions/VisualEditorwmf/1.46.0-wmf.22+4 -1
Fix suggestion mode availability checkEsandersmediawiki/extensions/VisualEditormaster+4 -1
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Apr 2 2026, 10:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2026, 10:59 AM
Esanders triaged this task as Unbreak Now! priority.Apr 2 2026, 10:59 AM
gerritbot added a comment.Apr 2 2026, 11:03 AM

Change #1266984 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Fix suggestion mode availability check

https://gerrit.wikimedia.org/r/1266984

gerritbot added a project: Patch-For-Review.Apr 2 2026, 11:03 AM

Change #1266985 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@wmf/1.46.0-wmf.22] Fix suggestion mode availability check

https://gerrit.wikimedia.org/r/1266985

Esanders moved this task from Decision to be made to Code Review on the Editing-team (Editing-Q4-30Mar-10Apr-2026) board.Apr 2 2026, 11:07 AM
gerritbot added a comment.Apr 2 2026, 12:07 PM

Change #1266984 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix suggestion mode availability check

https://gerrit.wikimedia.org/r/1266984

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.23; 2026-04-07).Apr 2 2026, 1:00 PM
gerritbot added a comment.Apr 2 2026, 1:50 PM

Change #1266985 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@wmf/1.46.0-wmf.22] Fix suggestion mode availability check

https://gerrit.wikimedia.org/r/1266985

Stashbot added a comment.Apr 2 2026, 1:51 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-02T13:51:25Z] <lucaswerkmeister-wmde@deploy1003> Started scap sync-world: Backport for [[gerrit:1266985|Fix suggestion mode availability check (T422143)]]

Stashbot added a comment.Apr 2 2026, 1:54 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-02T13:54:47Z] <lucaswerkmeister-wmde@deploy1003> Started scap sync-world: Backport for [[gerrit:1266985|Fix suggestion mode availability check (T422143)]]

Stashbot added a comment.Apr 2 2026, 1:58 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-02T13:58:53Z] <esanders@deploy1003> Started scap sync-world: Backport for [[gerrit:1266985|Fix suggestion mode availability check (T422143)]]

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.22; 2026-03-31); removed: MW-1.46-notes (1.46.0-wmf.23; 2026-04-07).Apr 2 2026, 2:00 PM
Stashbot added a comment.Apr 2 2026, 2:09 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-02T14:09:16Z] <esanders@deploy1003> Started scap sync-world: Backport for [[gerrit:1266985|Fix suggestion mode availability check (T422143)]]

Lucas_Werkmeister_WMDE mentioned this in T422166: scap can’t deploy (blob upload unknown) after apus.discovery.wmnet is repooled in codfw.Apr 2 2026, 2:13 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 2 2026, 2:31 PM
Stashbot added a comment.Apr 2 2026, 2:56 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-02T14:56:38Z] <swfrench@deploy1003> Started scap sync-world: Manual sync-world to pick up 1267062, 1266985 - T422143

Stashbot added a comment.Apr 2 2026, 2:59 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-02T14:59:40Z] <swfrench@deploy1003> Started scap sync-world: Manual full-rebuild sync-world to pick up 1267062, 1266985 - T422143

Stashbot added a comment.Apr 2 2026, 3:26 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-02T15:26:28Z] <swfrench@deploy1003> sync-world aborted: Manual full-rebuild sync-world to pick up 1267062, 1266985 - T422143 (duration: 26m 48s)

Stashbot added a comment.Apr 2 2026, 3:33 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-02T15:33:00Z] <swfrench@deploy1003> Started scap sync-world: Manual full-rebuild sync-world to pick up 1267062, 1266985 (attempt 2) - T422143

Stashbot added a comment.Apr 2 2026, 3:50 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-02T15:50:05Z] <swfrench@deploy1003> swfrench: Manual full-rebuild sync-world to pick up 1267062, 1266985 (attempt 2) - T422143 synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

ppelberg subscribed.Apr 2 2026, 3:58 PM

I was wondering what was going on here. Good data point for us.

image.png (1,530×786 px, 124 KB)

Stashbot added a comment.Apr 2 2026, 4:02 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-02T16:02:56Z] <swfrench@deploy1003> Finished scap sync-world: Manual full-rebuild sync-world to pick up 1267062, 1266985 (attempt 2) - T422143 (duration: 29m 56s)

Lucas_Werkmeister_WMDE lowered the priority of this task from Unbreak Now! to Needs Triage.Apr 2 2026, 4:04 PM
Lucas_Werkmeister_WMDE subscribed.

The fix should be deployed now (thanks swfrench!); lowering priority and leaving the rest to y’all.

DLynch subscribed.Apr 2 2026, 7:10 PM

It was also quite visible in the error stats, as increase(mediawiki_editcheck_errors_total[5m]) shows us:

CleanShot 2026-04-02 at 14.09.36@2x.png (3,274×1,006 px, 205 KB)

DLynch moved this task from Code Review to QA on the Editing-team (Editing-Q4-30Mar-10Apr-2026) board.Apr 2 2026, 7:22 PM
DLynch added a project: Editing QA.

The specific thing that made suggestions available was if you were a user who was also eligible for a check. So the testing criteria is:

  1. On a wikipedia (so checks are enabled)
  2. As a user who could see a check (config-dependent, but generally: <100 edits or logged out)
  3. As a user who does not have suggestion mode enabled via the beta feature, and who hasn't toggled suggestions off while the beta feature was enabled

If all that's true, you would see suggestions. You wouldn't see the suggestions toggle, however.

ppelberg removed a project: Editing-team (Editing-Q4-30Mar-10Apr-2026).Apr 15 2026, 4:38 PM
Esanders closed this task as Resolved.May 19 2026, 11:47 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits