Page MenuHomePhabricator
Create Task
Maniphest T422172

Ensure that we always set the action parameter as a query parameter when POSTing in WikiLambda code
Closed, ResolvedPublic
Actions

Description

Per parent.

  • Use of mw.api in resources/ext.wikilambda.app/utils/apiUtils.js (or make this automatic upstream?)
  • Use in AbstractWikiRequest

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
AbstractWikiRequest: Add the 'action' parameter as a query parametermediawiki/extensions/WikiLambdamaster+15 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Apr 2 2026, 2:43 PM
Jdforrester-WMF triaged this task as Medium priority.Apr 8 2026, 5:12 PM
Jdforrester-WMF moved this task from To Triage to Engineering Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF added a project: WikiLambda.
matmarex subscribed.Apr 27 2026, 5:40 PM

Use of mw.api in resources/ext.wikilambda.app/utils/apiUtils.js (or make this automatic upstream?)

apiUtils.js uses mw.Api, and mw.Api adds the action parameter to query parameters since https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1267086, so I guess this part is done?

Jdforrester-WMF added a comment.Apr 27 2026, 5:41 PM
In T422172#11862424, @matmarex wrote:

Use of mw.api in resources/ext.wikilambda.app/utils/apiUtils.js (or make this automatic upstream?)

apiUtils.js uses mw.Api, and mw.Api adds the action parameter to query parameters since https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1267086, so I guess this part is done?

Yup! Thanks. The other bit is still to do.

gerritbot added a comment.Apr 27 2026, 5:42 PM

Change #1277652 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/WikiLambda@master] AbstractWikiRequest: Add the 'action' parameter as a query parameter

https://gerrit.wikimedia.org/r/1277652

gerritbot added a project: Patch-For-Review.Apr 27 2026, 5:42 PM
matmarex added a comment.Apr 27 2026, 5:42 PM

It should be that simple, but I don't have the means to test it locally.

Jdforrester-WMF updated the task description. (Show Details)Apr 27 2026, 5:43 PM
In T422172#11862432, @matmarex wrote:

It should be that simple, but I don't have the means to test it locally.

Amazing, thanks; I will test it now.

Jdforrester-WMF changed the task status from Open to In Progress.Apr 27 2026, 5:56 PM
Jdforrester-WMF assigned this task to matmarex.
Jdforrester-WMF edited projects, added Abstract Wikipedia team (26Q4 (Apr–Jun)); removed Abstract Wikipedia team.
Jdforrester-WMF moved this task from Incoming to In Code review on the Abstract Wikipedia team (26Q4 (Apr–Jun)) board.
matmarex removed a parent task: T421288: Action API: prefer the action parameter to be given as a query parameter, even for POST requests.Apr 27 2026, 9:31 PM
matmarex added a subtask: T421288: Action API: prefer the action parameter to be given as a query parameter, even for POST requests.
matmarex closed subtask T421288: Action API: prefer the action parameter to be given as a query parameter, even for POST requests as Resolved.Apr 27 2026, 9:40 PM
gerritbot added a comment.Apr 28 2026, 10:52 AM

Change #1277652 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] AbstractWikiRequest: Add the 'action' parameter as a query parameter

https://gerrit.wikimedia.org/r/1277652

Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (26Q4 (Apr–Jun)) board.Apr 28 2026, 10:55 AM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.1; 2026-05-05).Apr 28 2026, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 28 2026, 11:31 AM
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (26Q4 (Apr–Jun)) board.May 6 2026, 7:03 PM
Jdforrester-WMF closed this task as Resolved.Tue, May 12, 3:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits