Page MenuHomePhabricator

Wrong section edit link target with Parsoid when section is transcluded
Open, Needs TriagePublicBUG REPORT

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

DiscussionTools reply doesn't work either.

We’ve talked about the wrong edit links in T368095: Parsoid shows bogus section edit links. It’s because template transclusions still use the legacy parser, and so Parsoid is not aware of where the heading actually comes from. (This is also why DiscussionTools doesn’t work – it only sees data Parsoid sees. So I wouldn’t call it a separate issue.) The task got closed, but this problem hasn’t been fixed, apparently not even almost two years later.

The task got closed, but this problem hasn’t been fixed

It was filed as T387520

Noting that the issue doesn't just affect small size Wikipedias, there are similar reports on German Wikipedia as well – and likely all other projects using Parsoid as the new default judging by the number of subscribers from different wikis.

Noting that the issue doesn't just affect small size Wikipedias, there are similar reports on German Wikipedia as well – and likely all other projects using Parsoid as the new default judging by the number of subscribers from different wikis.

Fair enough!
We've been partly using "small size" vs "larger" as a shorthand for "places where Parsoid is already the default" vs "places where it's not", but we may need to rename these milestones now that we did start deploying on larger Wikipedias :)

The new parser is still way too buggy to be used on productive projects. There are so many bugs linked to the new parser on German Wikipedia, it's really annoying. The deploying definitely started much too early.

This basically breaks the easiest ways to edit sections for templates with documentation pages. It is quite unfortunate that there is also no way to differentiate Parsoid-rendered pages from non-Parsoid ones via CSS since I’d rather hide those edit links while this bug is still active than mislead people into thinking they lead somewhere useful, like they did before.

It is quite unfortunate that there is also no way to differentiate Parsoid-rendered pages from non-Parsoid ones via CSS

Try .mw-parser-output[data-mw-parsoid-version]