Page MenuHomePhabricator

Preview warnings are not displayed in any way when using the visual editor.
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Navigate to a page where a preview warning should appear (for example this permalink of my sandbox)
  • Preview the page while using visual editor

What happens?:

  • No error warning is displayed

What should have happened instead?:

  • A red warning should have displayed saying Preview warning: Page using Template:Infobox person with unknown parameter "BAD_PARAM"
  • If you turn off the visual editor and edit the same permalink you will see the error message I am talking about.

Event Timeline

I think this is entirely on the VE side. Parsoid generates a ParserOutput, and the warnings should be present in ParserOutput::getWarningMsgs(). It's likely that VE's preview API doesn't actually return these to VE and/or VE doesn't have UX to display it, but I believe all the necessary information *should* be present from Parsoid.

We're untagging Parsoid for the moment. I couldn't verify exactly where this warning message is coming from -- I suspect it is added to the ParserOutput via lua code in the Infobox Scribunto module, and so should work the same for Parsoid and the legacy parser. If for some reason this warning isn't showing up in Parsoid's ParserOutput feel free to re-add the Parsoid tag.