Page MenuHomePhabricator

Special:NewPagesFeed "That" chips (e.g. Have no citations, Were previously deleted, etc.) do not display
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

image.png (1,113×378 px, 50 KB)

What happens?:

  • list of articles refreshes and changes its total, so I think the "Have no citations" filter is getting applied
  • however, a chip is not added for it. notice the absence of a "Have no citations" chip here:

image.png (1,494×90 px, 21 KB)

  • I also see JavaScript errors in the devtools console:

image.png (1,920×831 px, 177 KB)

What should have happened instead?:

  • list of articles refreshes and changes its total, so I think the "Have no citations" filter is getting applied
  • chip is added/updated
  • no devtools console erros

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1338300 had a related patch set uploaded (by Thilio; author: Thilio):

[mediawiki/extensions/PageTriage@master] PageTriage: Show the missing filter chips in NewPagesFeed (NPP & AfC).

https://gerrit.wikimedia.org/r/1338300

Also, I came across T413168, which described the same issue

Change #1338300 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] ShowingText: Show the missing filter chips in NewPagesFeed (NPP & AfC).

https://gerrit.wikimedia.org/r/1338300

@Thilio can I close this? Seems to be fixed in my testing.

In general, you can proactively close tickets once a patch is merged that fixes the ticket / fulfill's the ticket's acceptance criteria, + a WMF team wasn't the patch author.

With WMF teams, they often have a column on their Kanban board called QA (for test engineers to manually test the patch), so they need to keep their tickets open so that the ticket continues to appear on their Kanban board.