Page MenuHomePhabricator
Create Task
Maniphest T422358

Deprecate and remove Experiment#setStream(streamName)
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Description

Now that T408186: Configure experiments with stream, schema and contextual attributes has been shipped and we have configured already all the existing experiments with their stream_name and contextual_attributes in Test Kitchen UI, Experiment#setStream(streamName) is no longer needed and can be deprecated/removed. And that also means that wgTestKitchenExperimentStreamNames is not needed either.

Because the existing experiments have already their own configuration, the ExperimentManager (for both JS and PHP SDKs) will be instantiating experiments with all the needed configurations, so the following would be a valid approach:

  • Confirm that all existing experiment are updated with their own stream_name and contextual_attributes in Test Kitchen UI/API (/api/v1/experiments endpoint)
  • Remove Experiment#setStream call from the experiments code where it's being used
  • Remove Experiment#setStream from both Test Kitchen JS and PHP SDKs

Acceptance Criteria

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove `wgTestKitchenExperimentStreamNames`operations/mediawiki-configmaster+0 -15
Zuul: [mediawiki/extensions/TestKitchen] Remove EventStreamConfig dependencyintegration/configmaster+0 -2
Remove `Experiment#setStream` from JS and PHP SDKsmediawiki/extensions/TestKitchenmaster+8 -377
revise-tone experiment: Removing `Experiment#setStream` callsmediawiki/extensions/GrowthExperimentsmaster+1 -5
resources/experiments: Removing `Experiment#setStream` callsmediawiki/extensions/ReaderExperimentsmaster+0 -9
ext.wikimediaEvents: Removing `Experiment#setStream` callsmediawiki/extensions/WikimediaEventsmaster+10 -33
Deprecate Experiment#setStream for both JS and PHP SDKsmediawiki/extensions/TestKitchenmaster+2 -0
Customize query in gerrit

Related Objects

Event Timeline

Sfaci created this task.Apr 6 2026, 8:24 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2026, 8:24 AM
Sfaci updated the task description. (Show Details)Apr 6 2026, 9:00 AM
Sfaci set the point value for this task to 2.Apr 6 2026, 9:06 AM
Sfaci updated the task description. (Show Details)Apr 6 2026, 12:01 PM
KReid-WMF triaged this task as Medium priority.Apr 6 2026, 12:26 PM
KReid-WMF edited projects, added Test Kitchen (Test Kitchen (Experiment Platform Sprint 22)); removed Test Kitchen.
Sfaci updated the task description. (Show Details)Apr 21 2026, 9:59 AM
KReid-WMF edited projects, added Test Kitchen (Experiment Platform Sprint 23); removed Test Kitchen (Test Kitchen (Experiment Platform Sprint 22)).Apr 23 2026, 3:16 PM
Sfaci claimed this task.Apr 24 2026, 6:49 PM
Sfaci moved this task from Ready for Development to In Progress on the Test Kitchen (Experiment Platform Sprint 23) board.
gerritbot added a comment.Apr 24 2026, 7:03 PM

Change #1277173 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[mediawiki/extensions/TestKitchen@master] Deprecate Experiment#send for both JS and PHP SDKs

https://gerrit.wikimedia.org/r/1277173

gerritbot added a project: Patch-For-Review.Apr 24 2026, 7:03 PM
Sfaci moved this task from In Progress to Needs Review on the Test Kitchen (Experiment Platform Sprint 23) board.Apr 24 2026, 7:20 PM
gerritbot added a comment.Apr 27 2026, 12:44 PM

Change #1277537 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[mediawiki/extensions/WikimediaEvents@master] ext.wikimediaEvents: Removing `Experiment#setStream` calls

https://gerrit.wikimedia.org/r/1277537

Sfaci moved this task from Needs Review to In Progress on the Test Kitchen (Experiment Platform Sprint 23) board.Apr 27 2026, 12:53 PM
Sfaci moved this task from In Progress to Needs Review on the Test Kitchen (Experiment Platform Sprint 23) board.Apr 27 2026, 2:47 PM
Sfaci updated the task description. (Show Details)Apr 27 2026, 3:54 PM
gerritbot added a comment.Apr 27 2026, 5:22 PM

Change #1277173 merged by jenkins-bot:

[mediawiki/extensions/TestKitchen@master] Deprecate Experiment#setStream for both JS and PHP SDKs

https://gerrit.wikimedia.org/r/1277173

gerritbot added a comment.Apr 27 2026, 5:42 PM

Change #1277653 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[mediawiki/extensions/ReaderExperiments@master] resources/experiments: Removing `Experiment#setStream` calls

https://gerrit.wikimedia.org/r/1277653

phuedx moved this task from Needs Review to To Deploy on the Test Kitchen (Experiment Platform Sprint 23) board.Apr 27 2026, 6:00 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.26; 2026-04-28).Apr 27 2026, 6:00 PM
Sfaci moved this task from To Deploy to Needs Review on the Test Kitchen (Experiment Platform Sprint 23) board.Apr 28 2026, 10:40 PM
gerritbot added a comment.Apr 30 2026, 11:43 AM

Change #1280352 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[mediawiki/extensions/GrowthExperiments@master] revise-tone experiment: Removing `Experiment#setStream` calls

https://gerrit.wikimedia.org/r/1280352

gerritbot added a comment.Apr 30 2026, 12:27 PM

Change #1277537 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] ext.wikimediaEvents: Removing `Experiment#setStream` calls

https://gerrit.wikimedia.org/r/1277537

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.1; 2026-05-05).Apr 30 2026, 1:00 PM
Sfaci updated the task description. (Show Details)Apr 30 2026, 2:35 PM
Sfaci updated the task description. (Show Details)
Sfaci updated the task description. (Show Details)May 4 2026, 2:56 PM
gerritbot added a comment.May 5 2026, 10:44 AM

Change #1277653 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] resources/experiments: Removing `Experiment#setStream` calls

https://gerrit.wikimedia.org/r/1277653

ReleaseTaggerBot edited projects, added MW-1.47-notes (1.47.0-wmf.2; 2026-05-12); removed MW-1.47-notes (1.47.0-wmf.1; 2026-05-05).May 5 2026, 11:00 AM
gerritbot added a comment.May 5 2026, 11:33 AM

Change #1282957 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[mediawiki/extensions/TestKitchen@master] Remove `Experiment#setStream` from JS and PHP SDKs

https://gerrit.wikimedia.org/r/1282957

phuedx updated the task description. (Show Details)May 7 2026, 10:13 AM
gerritbot added a comment.May 7 2026, 11:09 AM

Change #1280352 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] revise-tone experiment: Removing `Experiment#setStream` calls

https://gerrit.wikimedia.org/r/1280352

phuedx updated the task description. (Show Details)May 7 2026, 11:16 AM
Sfaci moved this task from Needs Review to In Progress on the Test Kitchen (Experiment Platform Sprint 23) board.May 8 2026, 9:25 AM
gerritbot added a comment.May 8 2026, 4:57 PM

Change #1285412 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/mediawiki-config@master] Remove `wgTestKitchenExperimentStreamNames`

https://gerrit.wikimedia.org/r/1285412

Sfaci moved this task from In Progress to Needs Review on the Test Kitchen (Experiment Platform Sprint 23) board.May 8 2026, 5:54 PM
Sfaci updated the task description. (Show Details)May 8 2026, 8:00 PM

A couple of things are pending review:

KReid-WMF edited projects, added Test Kitchen (Experiment Platform Sprint 24); removed Test Kitchen (Experiment Platform Sprint 23).Thu, May 14, 3:10 PM
KReid-WMF moved this task from Ready for Development to Needs Review on the Test Kitchen (Experiment Platform Sprint 24) board.
gerritbot added a comment.Tue, May 19, 5:52 AM

Change #1282957 merged by jenkins-bot:

[mediawiki/extensions/TestKitchen@master] Remove `Experiment#setStream` from JS and PHP SDKs

https://gerrit.wikimedia.org/r/1282957

gerritbot added a comment.Tue, May 19, 5:55 AM

Change #1289154 had a related patch set uploaded (by Phuedx; author: Phuedx):

[integration/config@master] Zuul: [mediawiki/extensions/TestKitchen] Remove EventStreamConfig dependency

https://gerrit.wikimedia.org/r/1289154

phuedx moved this task from Needs Review to To Deploy on the Test Kitchen (Experiment Platform Sprint 24) board.Tue, May 19, 5:55 AM
ReleaseTaggerBot edited projects, added MW-1.47-notes (1.47.0-wmf.4; 2026-05-26); removed MW-1.47-notes (1.47.0-wmf.2; 2026-05-12).Tue, May 19, 6:00 AM
Sfaci updated the task description. (Show Details)Mon, May 25, 8:32 AM
gerritbot added a comment.Mon, Jun 1, 8:18 PM

Change #1285412 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove `wgTestKitchenExperimentStreamNames`

https://gerrit.wikimedia.org/r/1285412

Stashbot added a comment.Mon, Jun 1, 8:18 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-01T20:18:30Z] <catrope@deploy1003> Started scap sync-world: Backport for [[gerrit:1285412|Remove wgTestKitchenExperimentStreamNames (T422358)]], [[gerrit:1295531|Enable AbuseFilter block action on nlwiki (T427384)]]

Stashbot mentioned this in T427384: Enable Abusefilter "block" consequence on nlwiki.Mon, Jun 1, 8:18 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-01T20:20:15Z] <catrope@deploy1003> sfaci, xxblackburnxx, catrope: Backport for [[gerrit:1285412|Remove wgTestKitchenExperimentStreamNames (T422358)]], [[gerrit:1295531|Enable AbuseFilter block action on nlwiki (T427384)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Mon, Jun 1, 8:26 PM

Mentioned in SAL (#wikimedia-operations) [2026-06-01T20:26:18Z] <catrope@deploy1003> Finished scap sync-world: Backport for [[gerrit:1285412|Remove wgTestKitchenExperimentStreamNames (T422358)]], [[gerrit:1295531|Enable AbuseFilter block action on nlwiki (T427384)]] (duration: 07m 48s)

Sfaci moved this task from To Deploy to Done on the Test Kitchen (Experiment Platform Sprint 24) board.Tue, Jun 2, 9:15 AM
KReid-WMF closed this task as Resolved.Thu, Jun 4, 12:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits