At the moment sre.mysql.pool acts as a frontend for sre.mysql.parsercache and supports entire sections depooling, both parsercache and msX, so we should:
- Split pool/depool codebase as needed across pool.py and depool.py
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| sre.mysql: split pool/depool | Federico Ceratto | operations/cookbooks | master | +615 -481 |
Related Objects
Related Objects
Event Timeline
Comment Actions
@FCeratto-WMF I think for clarity maybe we need to rename this to:
sre.mysql.section or sre.mysql.pool-section
What do you think?
We should check if this existing cookbook is being used somewhere else
From a quick grep I only see it referenced in pool.py (as the delegate call) and its own tests, nothing else in the repo calls it directly. But can you double check?
Comment Actions
Last time we discussed it the idea was to use sre.mysql.pool as a frontend for pooling/depooling anything so we could merge the codebase together to keep it simple.
Comment Actions
Change #1295480 had a related patch set uploaded (by Federico Ceratto; author: Federico Ceratto):
[operations/cookbooks@master] sre.mysql: split pool/depool
Comment Actions
Depooled pc1023.eqiad.wmnet and pc2023.codfw.wmnet Depool test - fceratto@cumin1003 - T422361
Comment Actions
Depooled pc1023.eqiad.wmnet and pc2023.codfw.wmnet Pool test - fceratto@cumin1003 - T422361
Comment Actions
Depooled pc1023.eqiad.wmnet and pc2023.codfw.wmnet Depool test - fceratto@cumin1003 - T422361
Comment Actions
Depooled pc1023.eqiad.wmnet and pc2023.codfw.wmnet Pool test - fceratto@cumin1003 - T422361
Comment Actions
Change #1295480 merged by jenkins-bot:
[operations/cookbooks@master] sre.mysql: split pool/depool