Page MenuHomePhabricator
Create Task
Maniphest T422366

Allow read-only CentralNotice banner preview for logged-in users without the centralnotice-admin right
Closed, ResolvedPublic
Actions

Description

The banner preview functionality on Special:CentralNoticeBanners (when going into edit mode for a banner) does not work for users who do not have centralnotice-admin rights.

There is an error:

Error loading banner preview
You are not authorized to preview banners, or your edit token has expired. Please try logging in again or reloading the page.

In fixing T420810, all elements of the Special:CentralNoticeBanners/edit form are disabled for editing if the user does not have centralnotice-admin rights, and we removed the preview section of the page for users who are not allowed to view a preview.

As a follow up, we could allow preview to work for users without centralnotice-admin and then change the page to show the preview section again. Every other part of the form should remain disabled for editing. (view-only)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Restore banner preview link for non-editorsmediawiki/extensions/CentralNoticemaster+14 -7
Add banner preview link for non centralnotice adminsmediawiki/extensions/CentralNoticemaster+62 -44
Customize query in gerrit

Related Objects

Event Timeline

aude created this task.Apr 6 2026, 10:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2026, 10:53 AM
aude mentioned this in T420810: CentralNotice banner page lets people without permissions visually modify stuff.Apr 6 2026, 10:55 AM
Johannnes89 subscribed.Apr 6 2026, 10:58 AM
Johannnes89 added a comment.Apr 6 2026, 11:07 AM

Some related tasks / potential duplicates:

saper mentioned this in T424457: Uncaught TypeError: can't access property "WindowManager", OO.ui is undefined in MediaWiki:CentralNotice_Banner_Template_Intro.js.Apr 27 2026, 7:00 PM
saper subscribed.
gerritbot added a comment.May 2 2026, 12:31 PM

Change #1281760 had a related patch set uploaded (by Aude; author: Aude):

[mediawiki/extensions/CentralNotice@master] Add banner preview link users without centralnotice admin permissions

https://gerrit.wikimedia.org/r/1281760

gerritbot added a project: Patch-For-Review.May 2 2026, 12:31 PM
aude claimed this task.May 2 2026, 12:34 PM
aude added a project: Wikimedia-Hackathon-2026.
gerritbot added a comment.May 3 2026, 12:02 PM

Change #1281973 had a related patch set uploaded (by Ejegg; author: Ejegg):

[mediawiki/extensions/CentralNotice@master] Restore banner preview link for non-editors

https://gerrit.wikimedia.org/r/1281973

gerritbot added a comment.May 3 2026, 12:26 PM

Change #1281760 abandoned by Aude:

[mediawiki/extensions/CentralNotice@master] Add banner preview link for non centralnotice admins

https://gerrit.wikimedia.org/r/1281760

gerritbot added a comment.May 3 2026, 1:14 PM

Change #1281973 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@master] Restore banner preview link for non-editors

https://gerrit.wikimedia.org/r/1281973

Maintenance_bot removed a project: Patch-For-Review.May 3 2026, 1:31 PM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.1; 2026-05-05).May 3 2026, 2:00 PM
Aklapper moved this task from Backlog to Proposed Projects on the Wikimedia-Hackathon-2026 board.May 4 2026, 9:12 AM
DerHexer subscribed.May 7 2026, 10:26 PM
aude added a comment.Sat, May 23, 3:53 PM

This was fixed at the hackathon in Milan.

There is a [ Preview on wiki ] link for users without CentralNotice admin permissions to preview the banners.

aude closed this task as Resolved.Sat, May 23, 3:53 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits