Page MenuHomePhabricator
Create Task
Maniphest T422381

Do not write to database in GET request context when updating personaldashboard-eligible
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

We're seeing a lot of warnings from our newly created OpenSearch Dashboard:

This is because a database write is happening on render/GET, we should figure out a way to save this preference outside of the GET request lifecycle.
Since this preference relies on server side data checks, I bumped it up to 2 points as there's a bit more complexity to handling this.

Acceptance Criteria:

  • Warning is no longer appearing in our logstash dashboard
  • Database write happening in correct context

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Move save user option for personaldashboard-eligible to client sidemediawiki/extensions/PersonalDashboardmaster+31 -43
Use Deferred Updates when saving user preference personaldashboard-eligiblemediawiki/extensions/PersonalDashboardmaster+33 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Kgraessle created this task.Apr 6 2026, 2:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 6 2026, 2:03 PM
• Kgraessle updated the task description. (Show Details)Apr 6 2026, 2:04 PM
• Kgraessle claimed this task.Apr 8 2026, 9:02 AM
• Kgraessle triaged this task as High priority.
• Kgraessle moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
• Kgraessle set the point value for this task to 1.
Samwalton9-WMF moved this task from Backlog to Backend on the PersonalDashboard board.Apr 8 2026, 10:44 AM
gerritbot added a comment.Apr 8 2026, 11:57 AM

Change #1268931 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/PersonalDashboard@master] Use Deferred Updates when saving user preference personaldashboard-eligible

https://gerrit.wikimedia.org/r/1268931

gerritbot added a project: Patch-For-Review.Apr 8 2026, 11:57 AM
• Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Apr 8 2026, 12:14 PM
Dillon moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Apr 9 2026, 1:41 PM
gerritbot added a comment.Apr 9 2026, 1:53 PM

Change #1268931 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] Use Deferred Updates when saving user preference personaldashboard-eligible

https://gerrit.wikimedia.org/r/1268931

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.24; 2026-04-14).Apr 9 2026, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 9 2026, 2:31 PM
• Kgraessle renamed this task from Use Deferred Updates when saving user preference personaldashboard-eligible to Do not write to database in GET request context when updating personaldashboard-eligible.Apr 17 2026, 9:42 AM
• Kgraessle removed • Kgraessle as the assignee of this task.
• Kgraessle updated the task description. (Show Details)
• Kgraessle changed the point value for this task from 1 to 2.
• Kgraessle moved this task from QA to Ready on the Moderator-Tools-Team (Kanban) board.
Samwalton9-WMF added a parent task: T424026: WE1.11.2: Improve PersonalDashboard extension codebase.Apr 21 2026, 1:29 PM
Scardenasmolinar changed the task status from Open to In Progress.Apr 24 2026, 1:10 AM
Scardenasmolinar claimed this task.
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Apr 24 2026, 1:49 AM

Change #1276842 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PersonalDashboard@master] Move save user option for personaldashboard-eligible to client side

https://gerrit.wikimedia.org/r/1276842

gerritbot added a project: Patch-For-Review.Apr 24 2026, 1:49 AM
Scardenasmolinar moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Apr 24 2026, 3:16 AM
• Kgraessle moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Apr 27 2026, 9:18 AM
DMburugu moved this task from Reviewed (waiting for changes) to QA on the Moderator-Tools-Team (Kanban) board.Apr 28 2026, 3:06 PM
• Kgraessle moved this task from QA to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Apr 28 2026, 3:07 PM
Scardenasmolinar moved this task from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.Apr 29 2026, 1:19 AM
• Kgraessle moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Apr 29 2026, 11:32 AM
Dillon moved this task from Reviewed (waiting for changes) to QA on the Moderator-Tools-Team (Kanban) board.May 1 2026, 3:16 PM
gerritbot added a comment.May 1 2026, 3:21 PM

Change #1276842 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] Move save user option for personaldashboard-eligible to client side

https://gerrit.wikimedia.org/r/1276842

Maintenance_bot removed a project: Patch-For-Review.May 1 2026, 3:30 PM
ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.1; 2026-05-05).May 1 2026, 4:00 PM
Scardenasmolinar closed this task as Resolved.Wed, May 13, 6:08 PM
Scardenasmolinar moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.

Logstash seems to have no errors anymore. See screenshot for satisfying results:

Screenshot 2026-05-13 at 12.07.23.png (197×484 px, 17 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits