Maniphest T422457

Add better error handling for API usage
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Peter
	Apr 7 2026, 4:26 AM

Project Tags

Referenced Files

	F75318774: Screenshot 2026-04-08 at 13.31.47.png
	Apr 8 2026, 11:33 AM

Subscribers

Description

When trying to upgrade Wikibase I sometimes get errors like this:

00:06:28.377 [chrome-headless-shell 120.0.6099.224 linux #0-6] Cannot read properties of undefined (reading 'id')
00:06:28.377 [chrome-headless-shell 120.0.6099.224 linux #0-6] TypeError: Cannot read properties of undefined (reading 'id')
00:06:28.377 [chrome-headless-shell 120.0.6099.224 linux #0-6]     at WikibaseApi.createItem (file:///workspace/src/extensions/Wikibase/node_modules/wdio-wikibase/wikibase.api.js:70:26)

The problem is that when there's an error from the MW API, we just parse the JSON and return what we have. Before we rejected the promise with an error message. Lets make sure core do that (and log the actual error).

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	selenium: Catch MediaWiki API errors and log	mediawiki/core	master	+11 -1

Customize query in gerrit

Related Objects

Mentioned In: T422542: Release wdio-mediawiki 6.5.1

Event Timeline

Peter created this task.Apr 7 2026, 4:26 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 7 2026, 4:26 AM

Change #1268365 had a related patch set uploaded (by Phedenskog; author: Phedenskog):

[mediawiki/core@master] selenium: Catch MediaWiki API errors and log

https://gerrit.wikimedia.org/r/1268365

gerritbot added a project: Patch-For-Review.Apr 7 2026, 4:57 AM

Peter moved this task from Backlog to In Review on the Test Platform (Črnomerec 24) board.Apr 7 2026, 7:40 AM

Change #1268365 merged by jenkins-bot:

[mediawiki/core@master] selenium: Catch MediaWiki API errors and log

https://gerrit.wikimedia.org/r/1268365

Maintenance_bot removed a project: Patch-For-Review.Apr 7 2026, 9:30 AM

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.24; 2026-04-14).Apr 7 2026, 10:00 AM

Peter closed this task as Resolved.Apr 7 2026, 6:33 PM

Peter moved this task from In Review to Done on the Test Platform (Črnomerec 24) board.

Peter mentioned this in T422542: Release wdio-mediawiki 6.5.1.Apr 7 2026, 6:40 PM

This is an example of the fix that I could see in Wikibase (much better)

Screenshot 2026-04-08 at 13.31.47.png (2,288×388 px, 184 KB)