Sounds like it could be the same issue as T421633: ChronologyProtector not working reliably on the REST API…

I reused data from an item I retrieved using the REST API. I bet the problem is from reusing the Wikidata id's with what is perhaps a revision number at the end? The submissions had ids like this:

"id": "Q138961839$d93acd49-4bbd-4c82-b686-a28c2ae0d68f"

I figured it out. Those are statement IDs. I was including the statement ids from a REST API response when creating a new item. Removing those IDs from the payload fixes the problem. I can now create items and the statements are editable as expected.

I imagine other people will make this mistake, and it results in completely broken statements which can't be fixed by the user. The API needs to ensure this doesn't happen in the future. The existing statements in Wikidata items Q138974096 and Q138975112 are still completely broken and can't be edited or removed by users.

aaaaaa the statement ID contains the item ID of a different item than this one

In T422505#11794936, @Lucas_Werkmeister_WMDE wrote:

aaaaaa the statement ID contains the item ID of a different item than this one

why does the REST API allow this /o\

Yep! That's exactly it. I should have made that clear in my update. Since it is a new item, it won't have a Wikidata item id yet but you can still put one in.

Uploaded the payload for reference:

Change #1269098 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] CRUD: Ensure IDs of new statements are ignored

https://gerrit.wikimedia.org/r/1269098

Change #1269098 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] CRUD: Ensure IDs of new statements are ignored

https://gerrit.wikimedia.org/r/1269098

Regarding broken statements on Items like Q138974096, we see several ways to fix them via API, even by users.

Option 1) Using the PATCH method in REST API, by sending this request to https://www.wikidata.org/w/rest.php/wikibase/v1/entities/items/Q138974096:

{
  "patch": [
    {
      "op": "remove",
      "path": "/statements/P31/0/id"
    }
  ]
}

This will remove the invalid statement ID and automatically create a new valid one. Multiple remove operations can be sent in a single request.

Option 2) Using the Action API, by getting the entity json, manually replacing the incorrect item ID prefixes in the statement IDs, then saving it using wbeditentity with the clear parameter enabled (i.e. replace the whole entity).

@jwillikers Please let us know here whether you are comfortable applying the fixes or if you’d prefer us to do it.

In T422505#11824541, @Silvan_WMDE wrote:

Regarding broken statements on Items like Q138974096, we see several ways to fix them via API, even by users.

Option 1) Using the PATCH method in REST API, by sending this request to https://www.wikidata.org/w/rest.php/wikibase/v1/entities/items/Q138974096:

{
  "patch": [
    {
      "op": "remove",
      "path": "/statements/P31/0/id"
    }
  ]
}

This will remove the invalid statement ID and automatically create a new valid one. Multiple remove operations can be sent in a single request.

Option 2) Using the Action API, by getting the entity json, manually replacing the incorrect item ID prefixes in the statement IDs, then saving it using wbeditentity with the clear parameter enabled (i.e. replace the whole entity).

@jwillikers Please let us know here whether you are comfortable applying the fixes or if you’d prefer us to do it.

@Silvan_WMDE Thanks for the instructions! I've take care of that for Q138974096 and Q138975112 and they are editable again. Thanks again!

In T422505#11835843, @jwillikers wrote:

@Silvan_WMDE Thanks for the instructions! I've take care of that for Q138974096 and Q138975112 and they are editable again. Thanks again!

\o/