Page MenuHomePhabricator
Create Task
Maniphest T422512

Remove Navigation Menu Link Instrumentation
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In T407278: Instrument the Page Visit health metric for PersonalDashboard extension we instrumented the navigation link to the Personal Dashboard, however because the menu is rendered on every page, and we're targeting a 100% sample rate on enwiki, this is creating a lot of events.

We want to remove instrumentation from this link as it's not a high priority metric. In order to add it back we would need to create a separate instrumentation spec, which we have decided is not a priority right now.

Acceptance Criteria:

  • Remove instrumentation on the navigation link to the Personal Dashboard

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove Navigation Menu Link Instrumentation on Personal Dashboardmediawiki/extensions/WikimediaEventswmf/1.46.0-wmf.23+0 -11
Remove Navigation Menu Link Instrumentation on Personal Dashboardmediawiki/extensions/WikimediaEventswmf/1.46.0-wmf.22+0 -11
Remove Navigation Menu Link Instrumentation on Personal Dashboardmediawiki/extensions/WikimediaEventsmaster+0 -11
Customize query in gerrit

Related Objects

Event Timeline

Kgraessle created this task.Tue, Apr 7, 2:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Apr 7, 2:49 PM
Kgraessle triaged this task as High priority.Tue, Apr 7, 2:49 PM
Kgraessle added a project: OKR-Work (WE1 FY2025-26).
Kgraessle set the point value for this task to 1.
Kgraessle claimed this task.Tue, Apr 7, 2:52 PM
Kgraessle moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Tue, Apr 7, 3:00 PM

Change #1268577 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/WikimediaEvents@master] Remove Navigation Menu Link Instrumentation on Personal Dashboard

https://gerrit.wikimedia.org/r/1268577

gerritbot added a project: Patch-For-Review.Tue, Apr 7, 3:00 PM
Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Tue, Apr 7, 3:01 PM
Dillon moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Tue, Apr 7, 6:01 PM
gerritbot added a comment.Tue, Apr 7, 6:16 PM

Change #1268577 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Remove Navigation Menu Link Instrumentation on Personal Dashboard

https://gerrit.wikimedia.org/r/1268577

gerritbot added a comment.Tue, Apr 7, 6:21 PM

Change #1268625 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/WikimediaEvents@wmf/1.46.0-wmf.22] Remove Navigation Menu Link Instrumentation on Personal Dashboard

https://gerrit.wikimedia.org/r/1268625

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.24; 2026-04-14).Tue, Apr 7, 7:00 PM
gerritbot added a comment.Tue, Apr 7, 8:17 PM

Change #1268653 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/WikimediaEvents@wmf/1.46.0-wmf.23] Remove Navigation Menu Link Instrumentation on Personal Dashboard

https://gerrit.wikimedia.org/r/1268653

gerritbot added a comment.Tue, Apr 7, 9:02 PM

Change #1268625 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@wmf/1.46.0-wmf.22] Remove Navigation Menu Link Instrumentation on Personal Dashboard

https://gerrit.wikimedia.org/r/1268625

Stashbot mentioned this in T421629: TOC missing with Parsoid on some wikis (except for Vector 2022).Tue, Apr 7, 9:09 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-07T21:09:01Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1268600|Ensure RevisionOutputCache uses post-processing options where appropriate (T421629)]], [[gerrit:1268625|Remove Navigation Menu Link Instrumentation on Personal Dashboard (T422512)]], [[gerrit:1268633|ForeignWikiRequest: Pass session to internal 'centralauthtoken' request (T422218)]], [[gerrit:1268651|PHP SDK: Handle experiment config missing or

Stashbot mentioned this in T422218: Marking cross-wiki notifications as read doesn't work.Tue, Apr 7, 9:09 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-07T21:10:51Z] <cscott@deploy1003> cscott, kgraessle, sfaci, matmarex: Backport for [[gerrit:1268600|Ensure RevisionOutputCache uses post-processing options where appropriate (T421629)]], [[gerrit:1268625|Remove Navigation Menu Link Instrumentation on Personal Dashboard (T422512)]], [[gerrit:1268633|ForeignWikiRequest: Pass session to internal 'centralauthtoken' request (T422218)]], [[gerrit:1268651|PHP SDK: Handle experiment config

Stashbot added a comment.Tue, Apr 7, 9:17 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-07T21:17:54Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1268600|Ensure RevisionOutputCache uses post-processing options where appropriate (T421629)]], [[gerrit:1268625|Remove Navigation Menu Link Instrumentation on Personal Dashboard (T422512)]], [[gerrit:1268633|ForeignWikiRequest: Pass session to internal 'centralauthtoken' request (T422218)]], [[gerrit:1268651|PHP SDK: Handle experiment config missing or

gerritbot added a comment.Tue, Apr 7, 9:23 PM

Change #1268653 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@wmf/1.46.0-wmf.23] Remove Navigation Menu Link Instrumentation on Personal Dashboard

https://gerrit.wikimedia.org/r/1268653

Stashbot mentioned this in T422112: PHP Warning: Trying to access array offset on null.Tue, Apr 7, 9:31 PM
Stashbot mentioned this in T422394: CTT tasks week of 2026-04-03.
Maintenance_bot removed a project: Patch-For-Review.Tue, Apr 7, 9:31 PM
Stashbot added a comment.Tue, Apr 7, 9:31 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-07T21:31:06Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1268654|PHP SDK: Handle experiment config missing or malformed (T422112)]], [[gerrit:1268634|ForeignWikiRequest: Pass session to internal 'centralauthtoken' request (T422218)]], [[gerrit:1268653|Remove Navigation Menu Link Instrumentation on Personal Dashboard (T422512)]], [[gerrit:1268648|Bump wikimedia/parsoid to 0.23.0-a26 (T422394)]], [[gerrit:12686

Stashbot added a comment.Tue, Apr 7, 9:32 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-07T21:32:55Z] <cscott@deploy1003> matmarex, sfaci, cscott, kgraessle: Backport for [[gerrit:1268654|PHP SDK: Handle experiment config missing or malformed (T422112)]], [[gerrit:1268634|ForeignWikiRequest: Pass session to internal 'centralauthtoken' request (T422218)]], [[gerrit:1268653|Remove Navigation Menu Link Instrumentation on Personal Dashboard (T422512)]], [[gerrit:1268648|Bump wikimedia/parsoid to 0.23.0-a26 (T422394)]], [[g

Stashbot added a comment.Tue, Apr 7, 9:39 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-07T21:39:25Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1268654|PHP SDK: Handle experiment config missing or malformed (T422112)]], [[gerrit:1268634|ForeignWikiRequest: Pass session to internal 'centralauthtoken' request (T422218)]], [[gerrit:1268653|Remove Navigation Menu Link Instrumentation on Personal Dashboard (T422512)]], [[gerrit:1268648|Bump wikimedia/parsoid to 0.23.0-a26 (T422394)]], [[gerrit:1268

ReleaseTaggerBot edited projects, added MW-1.46-notes (1.46.0-wmf.23; 2026-04-07); removed MW-1.46-notes (1.46.0-wmf.24; 2026-04-14).Tue, Apr 7, 10:00 PM
Samwalton9-WMF moved this task from Backlog to Backend on the PersonalDashboard board.Wed, Apr 8, 10:44 AM
Scardenasmolinar closed this task as Resolved.Wed, Apr 8, 6:25 PM
Scardenasmolinar updated the task description. (Show Details)
Scardenasmolinar moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.
Scardenasmolinar subscribed.

Verified that this is working on test.wiki.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits