Page MenuHomePhabricator
Create Task
Maniphest T422553

Don't list closed wikis and metawiki in Special:CentralAuth's "wikis exempt from global block"-section
Closed, ResolvedPublic
Actions

Assigned To
Dreamy_Jazz
Authored By
Johannnes89
Apr 7 2026, 7:52 PM
Project Tags
Referenced Files
F75257140: Screenshot 2026-04-07 at 20.24.54.png
Apr 7 2026, 7:52 PM
F75257050: Screenshot 2026-04-07 at 20.23.28.png
Apr 7 2026, 7:52 PM
Subscribers
Aklapper
Dreamy_Jazz
HakanIST
Johannnes89

Description

New task per T422220#11796001

  • When globally blocking an account, wikis can disable the block locally. Special:CentralAuth will show this in a section "Wikis exempt from global block".
  • Recent changes introduced by T422220: Access of global_block_whitelist table on closed wikis through Special:CentralAuth causes exceptions led to "Wikis exempt from global block" also showing closed wikis -> global blocks no longer apply to those wikis due to T420062: Uninstall PSI extensions on closed wikis which are not needed.
  • The same changes in T422220 also led to Metawiki appearing as a wiki where global blocks don't apply. That's correct, but (except for occasional confusion by less experienced users) well known and documented – there's no need to suddenly show a large box explaining this on a special page which is already quite crowded.
  • Please restore the previous state of Special:CentralAuth and only show "Wikis exempt from global block" if the block has been disabled by local admins, don't show closed wikis and metawiki.

Screenshot 2026-04-07 at 20.23.28.png (868×684 px, 131 KB)

Screenshot 2026-04-07 at 20.24.54.png (1,486×1,220 px, 180 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Make GlobalBlockLocalStatusLookup::doGlobalBlocksApplyOnWiki publicmediawiki/extensions/GlobalBlockingmaster+11 -1
Special:CentralAuth: Hide local status on wikis without global blocksmediawiki/extensions/CentralAuthmaster+32 -3
Customize query in gerrit

Related Objects

Event Timeline

Johannnes89 created this task.Apr 7 2026, 7:52 PM
Restricted Application added projects: MediaWiki-Platform-Team, Product Safety and Integrity. · View Herald TranscriptApr 7 2026, 7:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Johannnes89 attached a referenced file: F75257140: Screenshot 2026-04-07 at 20.24.54.png. (Show Details)Apr 7 2026, 7:52 PM
Johannnes89 attached a referenced file: F75257050: Screenshot 2026-04-07 at 20.23.28.png. (Show Details)
Dreamy_Jazz edited projects, added: Essential-Work, Product Safety and Integrity (Sprint Forsythia (Mar 23 - Apr 10))); removed: Product Safety and Integrity.Apr 7 2026, 8:06 PM
Dreamy_Jazz added a comment.Apr 7 2026, 8:37 PM

We have some options:

  1. We hide this on Special:CentralAuth for all users
  2. We hide this on Special:CentralAuth for Stewards only
  3. We hide this on Special:CentralAuth just for WMF wikis

Any thoughts on the above ideas?

HakanIST subscribed.Apr 7 2026, 9:03 PM

Thanks for laying out the options. To me option 1 (filtering for all users) makes the most sense as these entries aren't actionable for anyone.

Looking at the code, the root cause seems to be that getLocalStatusInfo() returns a truthy array for wikis in $wgGlobalBlockingWikisWhereGlobalBlocksDoNotApply, which CentralAuth then displays as a real exemption. Making doGlobalBlocksApplyOnWiki() public and checking it in CentralAuth before calling getLocalStatusInfo() could be a clean fix. Happy to help with a patch if that direction works for you.

Dreamy_Jazz added a comment.EditedApr 7 2026, 10:24 PM
In T422553#11796616, @HakanIST wrote:

Looking at the code, the root cause seems to be that getLocalStatusInfo() returns a truthy array for wikis in $wgGlobalBlockingWikisWhereGlobalBlocksDoNotApply, which CentralAuth then displays as a real exemption.

Yes, this is because in the other ticket it was suggested to do that so that was just added by me.

It should be possible to make that method public and then use it in MediaWiki-extensions-CentralAuth depending on the finalised direction

matmarex moved this task from Inbox, needs triage to Radar on the MediaWiki-Platform-Team board.Apr 8 2026, 2:40 AM
matmarex edited projects, added: MediaWiki-Platform-Team (Radar); removed: MediaWiki-Platform-Team.
Dreamy_Jazz moved this task from Backlog to Ready on the Product Safety and Integrity (Sprint Forsythia (Mar 23 - Apr 10))) board.Apr 8 2026, 12:55 PM
gerritbot added a comment.Apr 10 2026, 9:24 AM

Change #1269977 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CentralAuth@master] Special:CentralAuth: Hide local status on wikis without global blocks

https://gerrit.wikimedia.org/r/1269977

gerritbot added a project: Patch-For-Review.Apr 10 2026, 9:24 AM
Dreamy_Jazz claimed this task.Apr 10 2026, 9:26 AM
Dreamy_Jazz moved this task from Ready to Needs review on the Product Safety and Integrity (Sprint Forsythia (Mar 23 - Apr 10))) board.
gerritbot added a comment.Apr 10 2026, 9:27 AM

Change #1269971 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Make GlobalBlockLocalStatusLookup::doGlobalBlocksApplyOnWiki public

https://gerrit.wikimedia.org/r/1269971

gerritbot added a comment.Apr 10 2026, 9:49 AM

Change #1269971 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Make GlobalBlockLocalStatusLookup::doGlobalBlocksApplyOnWiki public

https://gerrit.wikimedia.org/r/1269971

gerritbot added a comment.Apr 10 2026, 9:49 AM

Change #1269977 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Special:CentralAuth: Hide local status on wikis without global blocks

https://gerrit.wikimedia.org/r/1269977

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.24; 2026-04-14).Apr 10 2026, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 10 2026, 10:31 AM
Dreamy_Jazz moved this task from Needs review to Needs QA on the Product Safety and Integrity (Sprint Forsythia (Mar 23 - Apr 10))) board.Apr 10 2026, 10:40 AM
Dreamy_Jazz closed this task as Resolved.Apr 10 2026, 12:44 PM
• hector.arroyo moved this task from Needs QA to Done on the Product Safety and Integrity (Sprint Forsythia (Mar 23 - Apr 10))) board.Apr 20 2026, 8:43 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits