Page MenuHomePhabricator

Define and add Pinia storage for PersonalDashboard Review Changes module
Closed, ResolvedPublic5 Estimated Story Points

Description

To handle collating and selecting edits from multiple sources of edits for a given user, we would like to use a Pinia store. This will allow us to move faster in adding additional sources of changes to the Review Changes module.

Screenshot 2026-04-17 at 11.36.05.png (4,454×834 px, 415 KB)

The goal is to refactor our current composable function in a way that separates out the fetching of different sources as actions in a Pinia store.
For example right now we are fetching from Watchlist and Recent Changes (high risk changes) in one big function, but we could separate out some of this logic into different actions using Pinia and then merge them based on priority.
Our store getter would become the merged feed in the Pinia store.
We can also reference the PageTriage Pinia store for inspiration.

Acceptance Criteria:

  • Define a new Pinia store interface (The store should be designed to easily support additional feed sources without modifying existing merge logic)
  • Create Pinia actions for fetching the individual feed sources (can use composables here)
  • Create a mergedFeed getter that consolidates the different source actions based on priority and weight (TBD, for now we're doing quota method).
  • Ensure each action returns normalized data (consistent shape across feeds)
  • Move shared transformation logic (e.g. filtering, tagging, deduplication) into reusable helpers

Event Timeline

Might working on this fix T422016?

Scardenasmolinar changed the task status from Open to In Progress.May 8 2026, 6:38 PM
Scardenasmolinar claimed this task.

Change #1289049 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PersonalDashboard@master] Add Pinia store to RiskyArticles

https://gerrit.wikimedia.org/r/1289049

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://94168f07b2.catalyst.wmcloud.org/w/

Might working on this fix T422016?

We investigated the root cause of T422016: In Review Changes module, edits rearrange after initial page load on mobile during engineering today, and confirmed this bug is unrelated to Pinia. I am working on a separate patch that will remedy the edits rearranging issue!

Change #1289049 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] Add Pinia store to RiskyArticles

https://gerrit.wikimedia.org/r/1289049

Change #1299592 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PersonalDashboard@master] Add tests for new reviewChangesStore

https://gerrit.wikimedia.org/r/1299592

Change #1299592 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] Add tests for new reviewChangesStore

https://gerrit.wikimedia.org/r/1299592

Scardenasmolinar moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.

On testwiki, nothing broke, and we can see that Pinia is being used.

Test wiki on Patch demo by SCardenas (WMF) using patch(es) linked to this task was deleted:

https://94168f07b2.catalyst.wmcloud.org/w/