Page MenuHomePhabricator
Create Task
Maniphest T422667

Use Deferred Updates when saving user preference personaldashboard-visited
Open, HighPublic2 Estimated Story Points
Actions

Description

We're seeing a lot of warnings from our newly created OpenSearch Dashboard (round 2):

This is because a database write is happening on render, we should make sure to wrap this preference update call in a Deferred Update like so:

DeferredUpdates::addCallableUpdate

Acceptance Criteria:
Warning is no longer appearing in our logstash dashboard
Database write happening at end of request

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use Deferred Updates when saving user preference personaldashboard-visitedmediawiki/extensions/PersonalDashboardmaster+22 -3
Customize query in gerrit

Event Timeline

Kgraessle created this task.Wed, Apr 8, 2:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Apr 8, 2:18 PM
Kgraessle claimed this task.Wed, Apr 8, 2:28 PM
Kgraessle triaged this task as High priority.
Kgraessle set the point value for this task to 2.
Kgraessle moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Thu, Apr 9, 9:55 AM

Change #1269374 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/PersonalDashboard@master] Use Deferred Updates when saving user preference personaldashboard-visited

https://gerrit.wikimedia.org/r/1269374

gerritbot added a project: Patch-For-Review.Thu, Apr 9, 9:55 AM
Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Thu, Apr 9, 10:17 AM
Dillon moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Thu, Apr 9, 2:38 PM
Kgraessle moved this task from Reviewed (waiting for changes) to In Progress on the Moderator-Tools-Team (Kanban) board.Fri, Apr 10, 7:41 AM
Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Fri, Apr 10, 9:50 AM
Samwalton9-WMF moved this task from Backlog to Backend on the PersonalDashboard board.Fri, Apr 10, 11:55 AM
gerritbot added a comment.Fri, Apr 10, 3:15 PM

Change #1269374 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] Use Deferred Updates when saving user preference personaldashboard-visited

https://gerrit.wikimedia.org/r/1269374

Maintenance_bot removed a project: Patch-For-Review.Fri, Apr 10, 3:31 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.24; 2026-04-14).Fri, Apr 10, 4:00 PM
Dillon moved this task from Eng review to QA on the Moderator-Tools-Team (Kanban) board.Fri, Apr 10, 8:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits