Page MenuHomePhabricator

Define and implement any missing metrics needed for Suggestion Mode controlled experiment
Closed, ResolvedPublic

Description

This task involves the work of ensuring all of the metrics specified within the Suggestion Mode MVP controlled experiment measurement plan are implemented within the Test Kitchen metrics catalog.

Open question(s)

  • 1. Will people who are logged in and published ≥100 cumulative edits be included in the experiment? If so, we'll need to update the metric definitions to explicitly exclude anyone NOT in these groups.

Requirements

  1. Review the metrics specified in the Suggestion Mode MVP controlled experiment measurement plan
  2. Identify what (if any) metrics are not yet implemented within the Test Kitchen metrics catalog
  3. For any metrics that are not yet implemented within the Test Kitchen metrics catalog, define and implement them

Done

  • All Requirements are addressed

Note: this task being resolved does not need to block the start of the controlled experiment. Although, until this work is completed, all metrics specified within the measurement plan will not be available within Superset.

Event Timeline

Change #1271752 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[mediawiki/extensions/WikimediaEvents@master] Add maintenance script for constructive edits

https://gerrit.wikimedia.org/r/1271752

Change #1272633 had a related patch set uploaded (by Clare Ming; author: Clare Ming):

[operations/puppet@production] Add script to get constructive edits for all wikis

https://gerrit.wikimedia.org/r/1272633

Change #1271752 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Add maintenance script for constructive edits

https://gerrit.wikimedia.org/r/1271752

Change #1279510 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/WikimediaEvents@master] Suggestion Mode controlled experiment: limit exposure to newcomers

https://gerrit.wikimedia.org/r/1279510

Change #1279510 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Suggestion Mode controlled experiment: limit exposure to newcomers

https://gerrit.wikimedia.org/r/1279510

Change #1280516 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/WikimediaEvents@wmf/1.46.0-wmf.26] Suggestion Mode controlled experiment: limit exposure to newcomers

https://gerrit.wikimedia.org/r/1280516

Change #1280516 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@wmf/1.46.0-wmf.26] Suggestion Mode controlled experiment: limit exposure to newcomers

https://gerrit.wikimedia.org/r/1280516

Mentioned in SAL (#wikimedia-operations) [2026-04-30T20:42:25Z] <jhuneidi@deploy1003> Started scap sync-world: Backport for [[gerrit:1280516|Suggestion Mode controlled experiment: limit exposure to newcomers (T422736)]], [[gerrit:1280552|Abandon the editor survey: update edit count restriction (T422931)]]

Mentioned in SAL (#wikimedia-operations) [2026-04-30T20:44:05Z] <jhuneidi@deploy1003> caro, jhuneidi: Backport for [[gerrit:1280516|Suggestion Mode controlled experiment: limit exposure to newcomers (T422736)]], [[gerrit:1280552|Abandon the editor survey: update edit count restriction (T422931)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-04-30T20:50:59Z] <jhuneidi@deploy1003> Finished scap sync-world: Backport for [[gerrit:1280516|Suggestion Mode controlled experiment: limit exposure to newcomers (T422736)]], [[gerrit:1280552|Abandon the editor survey: update edit count restriction (T422931)]] (duration: 08m 33s)

I submitted an MR to add metrics for the suggestion mode experiment and register the experiment for analysis. The merge of MR is pending review and a fix to a current bug with Test Kitchen Automated Analysis (T426203).

ppelberg added subscribers: cjming, DLynch.

Resolving; @DLynch will file a ticket to hold us accountable to making a decision about what (if anything) we want to do with the unmerged patch he and @cjming wrote at the SDS offsite.