Page MenuHomePhabricator
Create Task
Maniphest T422740

Implement Suggestion Mode instrumentation spec in Test Kitchen
Closed, ResolvedPublic
Actions

Description

This task involves the work of ensuring that all events defined within the WE 1.7 Edit Suggestions Instrumentation Spec are implemented within Test Kitchen.

Requirements

  1. Review all events defined in Column D (Relevant VEFU/EAS Fields) of the WE 1.7 Edit Suggestions Instrumentation Spec
  2. For any events defined in Column D that are not implemented within Column E (Test Kitchen Interaction Fields (will only be needed if we use TestKitchen)), propose names for these events, and implement them
    • Question: where does this implementation happen?

Done

  • All specified events are implemented both within VEFU and Test Kitchen
  • @MNeisler or @mpopov review proposed implementation

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Backwards compatibility for mw.testKitchen.compat (ironically)DLynchmediawiki/extensions/WikimediaEventswmf/1.46.0-wmf.24+1 -1
Backwards compatibility for mw.testKitchen.compat (ironically)DLynchmediawiki/extensions/WikimediaEventsmaster+1 -1
Add experiment for suggestion mode beta featureEsandersmediawiki/extensions/WikimediaEventswmf/1.46.0-wmf.24+175 -0
Add experiment for suggestion mode beta featureMedeliusmediawiki/extensions/WikimediaEventsmaster+175 -0
Suggestion mode controlled experiment: use treatment group configMedeliusmediawiki/extensions/VisualEditormaster+4 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

ppelberg created this task.Apr 8 2026, 8:56 PM
ppelberg triaged this task as High priority.
ppelberg moved this task from Decision to be made to Ready for Dev on the Editing-team (Editing-Q4-13Apr-24Apr-2026) board.
VPuffetMichel subscribed.Apr 13 2026, 5:32 PM

we cannot estimate this. David L is the one usually working with testkitchen.

VPuffetMichel added a comment.Apr 13 2026, 5:33 PM

Caro will have a look and work with David L.

medelius subscribed.Apr 15 2026, 5:16 PM

I've gotten context from David L and will begin working on this!

medelius claimed this task.Apr 15 2026, 5:16 PM
medelius moved this task from Ready for Dev to Dev Doing on the Editing-team (Editing-Q4-13Apr-24Apr-2026) board.
gerritbot added a comment.Apr 16 2026, 2:37 PM

Change #1272741 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/WikimediaEvents@master] WIP: Add experiment for suggestion mode beta feature

https://gerrit.wikimedia.org/r/1272741

gerritbot added a project: Patch-For-Review.Apr 16 2026, 2:37 PM
ppelberg mentioned this in T404600: [MILESTONE] Run controlled experiment of Suggestion Mode MVP.Apr 16 2026, 11:23 PM
gerritbot added a comment.Apr 20 2026, 7:32 PM

Change #1275510 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/VisualEditor@master] Suggestion mode controlled experiment: check assigned group

https://gerrit.wikimedia.org/r/1275510

medelius moved this task from Dev Doing to Code review on the Editing-team (Editing-Q4-13Apr-24Apr-2026) board.Apr 21 2026, 3:27 PM
ppelberg added a comment.Apr 21 2026, 9:37 PM

Next steps

Per today's offline discussion...

  • 1. @medelius to talk with @DLynch to:
    • Decide what (if anything) about the proposed implementation needs revision/adjustment
    • If changes are needed, decide who will implement them and when and who will backport them
gerritbot added a comment.Apr 23 2026, 6:22 PM

Change #1275510 abandoned by Medelius:

[mediawiki/extensions/VisualEditor@master] Suggestion mode controlled experiment: use treatment group config

Reason:

We're just going to enable the beta feature from the experiment code in 1272741.

https://gerrit.wikimedia.org/r/1275510

gerritbot added a comment.Apr 25 2026, 4:24 PM

Change #1272741 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Add experiment for suggestion mode beta feature

https://gerrit.wikimedia.org/r/1272741

Maintenance_bot removed a project: Patch-For-Review.Apr 25 2026, 4:31 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.26; 2026-04-28).Apr 25 2026, 5:00 PM
gerritbot added a comment.Apr 27 2026, 11:19 AM

Change #1277496 had a related patch set uploaded (by Esanders; author: Medelius):

[mediawiki/extensions/WikimediaEvents@wmf/1.46.0-wmf.24] Add experiment for suggestion mode beta feature

https://gerrit.wikimedia.org/r/1277496

gerritbot added a project: Patch-For-Review.Apr 27 2026, 11:19 AM
gerritbot added a comment.Apr 27 2026, 1:46 PM

Change #1277496 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@wmf/1.46.0-wmf.24] Add experiment for suggestion mode beta feature

https://gerrit.wikimedia.org/r/1277496

Stashbot added a comment.Apr 27 2026, 1:46 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-27T13:46:41Z] <esanders@deploy1003> Started scap sync-world: Backport for [[gerrit:1277496|Add experiment for suggestion mode beta feature (T422740)]]

Stashbot added a comment.Apr 27 2026, 1:48 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-27T13:48:15Z] <esanders@deploy1003> esanders: Backport for [[gerrit:1277496|Add experiment for suggestion mode beta feature (T422740)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Apr 27 2026, 1:54 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-27T13:54:08Z] <esanders@deploy1003> Finished scap sync-world: Backport for [[gerrit:1277496|Add experiment for suggestion mode beta feature (T422740)]] (duration: 07m 26s)

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.24; 2026-04-14); removed: MW-1.46-notes (1.46.0-wmf.26; 2026-04-28).Apr 27 2026, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 27 2026, 2:33 PM
gerritbot added a comment.Apr 27 2026, 2:49 PM

Change #1277571 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/WikimediaEvents@master] Backwards compatibility for mw.testKitchen.compat (ironically)

https://gerrit.wikimedia.org/r/1277571

gerritbot added a project: Patch-For-Review.Apr 27 2026, 2:49 PM

Change #1277572 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/WikimediaEvents@wmf/1.46.0-wmf.24] Backwards compatibility for mw.testKitchen.compat (ironically)

https://gerrit.wikimedia.org/r/1277572

gerritbot added a comment.Apr 27 2026, 3:03 PM

Change #1277571 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] Backwards compatibility for mw.testKitchen.compat (ironically)

https://gerrit.wikimedia.org/r/1277571

gerritbot added a comment.Apr 27 2026, 3:44 PM

Change #1277572 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@wmf/1.46.0-wmf.24] Backwards compatibility for mw.testKitchen.compat (ironically)

https://gerrit.wikimedia.org/r/1277572

Stashbot added a comment.Apr 27 2026, 3:44 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-27T15:44:45Z] <kemayo@deploy1003> Started scap sync-world: Backport for [[gerrit:1277572|Backwards compatibility for mw.testKitchen.compat (ironically) (T422740)]]

Stashbot added a comment.Apr 27 2026, 3:46 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-27T15:46:25Z] <kemayo@deploy1003> kemayo: Backport for [[gerrit:1277572|Backwards compatibility for mw.testKitchen.compat (ironically) (T422740)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

ReleaseTaggerBot edited projects, added: MW-1.46-notes (1.46.0-wmf.26; 2026-04-28); removed: MW-1.46-notes (1.46.0-wmf.24; 2026-04-14).Apr 27 2026, 4:00 PM
Stashbot added a comment.Apr 27 2026, 4:00 PM

Mentioned in SAL (#wikimedia-operations) [2026-04-27T16:00:42Z] <kemayo@deploy1003> Finished scap sync-world: Backport for [[gerrit:1277572|Backwards compatibility for mw.testKitchen.compat (ironically) (T422740)]] (duration: 15m 57s)

medelius moved this task from Code review to Ready for Sign off on the Editing-team (Editing-Q4-13Apr-24Apr-2026) board.Apr 27 2026, 4:20 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 27 2026, 4:31 PM
ppelberg added a comment.Apr 29 2026, 2:33 PM

@medelius: to be doubly sure, would it be accurate for me to think Megan and Mikhail have review the proposed implementation?

ppelberg edited projects, added: Editing-team (Editing-Q4-27Apr-8May-2026); removed: Editing-team (Editing-Q4-13Apr-24Apr-2026).Apr 29 2026, 8:18 PM
medelius added a comment.Apr 30 2026, 12:38 AM

Mikhail did a code review pass, so I think we could say that?

ppelberg closed this task as Resolved.Apr 30 2026, 11:43 AM
In T422740#11873892, @medelius wrote:

Mikhail did a code review pass, so I think we could say that?

Sounds great. Thank you for confirming, Caro.

ppelberg updated the task description. (Show Details)Apr 30 2026, 11:43 AM
VPuffetMichel edited projects, added: OKR-Work; removed: OKR-Work (WE1 FY2025-26).Jul 3 2026, 8:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits