Description

This task specifically targets the reduction of RequestContext::getMain outside test code. There are 93 files using RequestContext at the moment:
https://codesearch.wmcloud.org/core/?q=RequestContext%3A%3AgetMain&files=%5C.php&excludeFiles=phpunit

After a quick pass to identify cases where the reference can easily be deprecated or removed, a next step would be to group the remaining use cases to identify how problematic the reference is, and potentially what one would to do to remove the global context reference.

If a class is touched, we should be careful with regard to hook runners, where an extension may read from RequestContext.

I have identified the following callsites as likely simple to adjust, but did not create a change yet (mostly because I want my number of concurrent patchsets overseeable)

SpecialPageFactory::getUsablePages: Few callers, simple to migrate
UploadBase::checkWarnings: Few callers, simple to migrate
UploadBase::isValidRequest: should take a user parameter, which is available at the callers
... (feel free to add things here)

Subject	Repo	Branch	Lines +/-
Deprecate calling UploadBase::checkWarnings without user	mediawiki/core	master	+8 -2
Hard-deprecate calling HTMLForm::loadInputFromParameters without parent	mediawiki/core	master	+7 -0
Get SecurityLogContext from local context if possible	mediawiki/core	master	+2 -4
Avoid using global request in Rest entry point	mediawiki/core	master	+1 -1
Remove unreachable RequestContext fallback	mediawiki/core	master	+4 -7

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T422741 Reduce uses of RequestContext::getMain in MediaWiki code
Open	None	T422745 Reduce use of RequestContext::getMain in MediaWiki core (outside test code)
Resolved	MGChecker	T422379 Deprecate and remove calling ChangesList methods without context
Open	None	T330109 Disallow reference to RequestContext in ServiceWiring
Open	Catrope	T399517 Codex-PHP should accept language from local context instead of global RequestContext
Open	MGChecker	T422749 Hard-deprecate and remove ContentHandler::getPageViewLanguage
Open	None	T423038 Remove HTMLFormField context fallbacks
Open	None	T423274 Figure out a way to pass the context WebRequest to RecentChangeStore
Open	MGChecker	T423415 Remove context fallback in SpecialPageFactory::getUsablePages
Open	None	T423611 Do not use global context for timestamp rendering
Open	None	T423621 Do not use global context in ContentHandler::createTextSlotDiffRenderer

Event Timeline

MGChecker created this task.Wed, Apr 8, 9:05 PM

MGChecker added a subtask: T422379: Deprecate and remove calling ChangesList methods without context.

Change #1269057 had a related patch set uploaded (by MGChecker; author: MGChecker):

[mediawiki/core@master] Hard-deprecate calling HTMLForm::loadInputFromParameters without parent

https://gerrit.wikimedia.org/r/1269057

Change #1268106 had a related patch set uploaded (by MGChecker; author: MGChecker):

[mediawiki/core@master] Avoid using global request in Rest entry point

https://gerrit.wikimedia.org/r/1268106

Change #1268114 had a related patch set uploaded (by MGChecker; author: MGChecker):

[mediawiki/core@master] Remove unreachable RequestContext fallback

https://gerrit.wikimedia.org/r/1268114

MGChecker added a subtask: T330109: Disallow reference to RequestContext in ServiceWiring.Wed, Apr 8, 9:11 PM

MGChecker updated the task description. (Show Details)Wed, Apr 8, 9:15 PM

MGChecker added a subtask: T399517: Codex-PHP should accept language from local context instead of global RequestContext.

At the moment, I am referencing this task directly if we have just a single, rather simple isolated change, and create subtasks for things which involve multiple correlated changes.

MGChecker updated the task description. (Show Details)Wed, Apr 8, 9:23 PM

Once a probable need of bigger refactorings is identified for certain callsites, an individual task should be created.

MGChecker created subtask T422749: Hard-deprecate and remove ContentHandler::getPageViewLanguage.Wed, Apr 8, 9:33 PM

Change #1268114 merged by jenkins-bot:

[mediawiki/core@master] Remove unreachable RequestContext fallback

https://gerrit.wikimedia.org/r/1268114

ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.24; 2026-04-14).Wed, Apr 8, 10:00 PM

Change #1269085 had a related patch set uploaded (by MGChecker; author: MGChecker):

[mediawiki/core@master] Get SecurityLogContext from local context if possible

https://gerrit.wikimedia.org/r/1269085

Bugreporter updated the task description. (Show Details)Thu, Apr 9, 1:40 AM

Bugreporter2 awarded a token.Thu, Apr 9, 2:33 AM