Hard-deprecate and remove ContentHandler::getPageViewLanguage
Open, Needs TriagePublic
Actions

Description

The only remaining callsite of this soft-deprecated method is in Wikibase. Removing it will allow to get rid of quite a few extension callsites of RequestContext.

Details

Related Changes in Gerrit:

Subject	Author	Repo	Branch	Lines +/-
Clean up cache splitting by userlang in EntityHandler	MGChecker	mediawiki/extensions/Wikibase	master	+25 -34
Remove EntityHandler::getPageViewLanguage()	SomeRandomDeveloper	mediawiki/extensions/Wikibase	master	+2 -55
Remove unused EntitySchemaContentHandler::getPageViewLanguage()	SomeRandomDeveloper	mediawiki/extensions/EntitySchema	master	+0 -18

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T11968 Reduce use of global and public variables
Open	None	T422741 Reduce uses of RequestContext::getMain in MediaWiki code
Open	None	T422745 Reduce use of RequestContext::getMain in MediaWiki core (outside test code)
Open	MGChecker	T422749 Hard-deprecate and remove ContentHandler::getPageViewLanguage

Event Timeline

MGChecker created this task.Apr 8 2026, 9:33 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptApr 8 2026, 9:33 PM

Change #1268956 had a related patch set uploaded (by MGChecker; author: MGChecker):

[mediawiki/extensions/Wikibase@master] Replace deprecated method getPageViewLanguage

https://gerrit.wikimedia.org/r/1268956

gerritbot added a project: Patch-For-Review.Apr 8 2026, 9:34 PM

MGChecker claimed this task.Apr 8 2026, 10:11 PM

MGChecker edited projects, added: Wikibase Architecture; removed: Goal.Apr 9 2026, 2:30 PM

Pppery edited projects, added: MediaWiki-ContentHandler; removed: MediaWiki-General.May 13 2026, 8:03 PM

@Lucas_Werkmeister_WMDE Can something be done to have the patch landing anytime soon?

Change #1338219 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: SomeRandomDeveloper):

[mediawiki/extensions/Wikibase@master] Remove EntityHandler::getPageViewLanguage()

https://gerrit.wikimedia.org/r/1338219

Change #1338222 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: SomeRandomDeveloper):

[mediawiki/extensions/EntitySchema@master] Remove unused EntitySchemaContentHandler::getPageViewLanguage()

https://gerrit.wikimedia.org/r/1338222

thiemowmde added a project: Wikidata-Omega (The Board).Thu, Oct 8, 8:24 AM

thiemowmde moved this task from new to the board to In Peer Review on the Wikidata-Omega (The Board) board.

thiemowmde subscribed.

Maintenance_bot added a project: Wikidata.Thu, Oct 8, 8:30 AM

Change #1338222 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Remove unused EntitySchemaContentHandler::getPageViewLanguage()

https://gerrit.wikimedia.org/r/1338222

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.24; 2026-10-13).Thu, Oct 8, 9:00 AM

Change #1338219 merged by jenkins-bot: