Page MenuHomePhabricator

#p-personal disappeared
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?: That script doesn't display

What should have happened instead?: The script does display.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Specifically the issue is that HTML is being served like this:

<div id="" class="vector-menu mw-portlet mw-portlet-personal"

Normally it would be id="p-personal"

Change #1269718 had a related patch set uploaded (by Aude; author: Aude):

[mediawiki/skins/Vector@master] Re-add p-personal id to the user menu

https://gerrit.wikimedia.org/r/1269718

Diff of pre- and post- patch 1262192 (the patch that caused the regression)

image.png (2,155×1,008 px, 479 KB)

  • id="p-portlet" obviously, fixed in a hotfix above
  • title="User menu" may also need to be added back, wasn't included in the above hotfix
  • do we care about all the blank element attributes that have been added, e.g. data-mw-interface="" and class=""?

Change #1269718 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Re-add p-personal id to the user menu

https://gerrit.wikimedia.org/r/1269718

Change #1270026 had a related patch set uploaded (by Aude; author: Aude):

[mediawiki/skins/Vector@master] Preserve title attribute for user menu

https://gerrit.wikimedia.org/r/1270026

In the patch that caused the regression, we switched the menu items to use Link.mustache so that the menu items can optionally have icons. Link.mustache includes data-mw-interface which I think is to indicate it is trusted markup generated by MediaWiki. Previously it was using html for the links that was generated in MediaWiki core and does not have data-mw-interface there.

Change #1270043 had a related patch set uploaded (by Aude; author: Aude):

[mediawiki/skins/Vector@wmf/1.46.0-wmf.23] Re-add p-personal id to the user menu

https://gerrit.wikimedia.org/r/1270043

Change #1270043 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.46.0-wmf.23] Re-add p-personal id to the user menu

https://gerrit.wikimedia.org/r/1270043

Mentioned in SAL (#wikimedia-operations) [2026-04-13T13:38:39Z] <lucaswerkmeister-wmde@deploy1003> Started scap sync-world: Backport for [[gerrit:1270043|Re-add p-personal id to the user menu (T422885)]]

Mentioned in SAL (#wikimedia-operations) [2026-04-13T13:42:17Z] <lucaswerkmeister-wmde@deploy1003> lucaswerkmeister-wmde, aude: Backport for [[gerrit:1270043|Re-add p-personal id to the user menu (T422885)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-04-13T13:49:20Z] <lucaswerkmeister-wmde@deploy1003> Finished scap sync-world: Backport for [[gerrit:1270043|Re-add p-personal id to the user menu (T422885)]] (duration: 10m 41s)

I can confirm the backport has got this working again.

Per @Novem_Linguae comment, the latest patch (not deployed in production yet) restores the title attribute. The additional attributes like data-mw attribute should be considered in another ticket if necessary. That's a side effect of switching to the Link.mustache template from the legacy template and adding icon support.

Change #1270026 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Preserve tooltip for user menu

https://gerrit.wikimedia.org/r/1270026

HFan-WMF claimed this task.