Sorry about this. Fixing now. Thanks for reporting it!

The mw.motify toast has now been replaced by a Codex popover component, and this bug has been fixed in that:

It does look like we need to fix up the dropdown scroll behaviour in some situations (I'll open a separate task for that).

Got a link to the patch for this one? Did it ride the train? Testwiki still has this bug with the extra margin-top between items in the dropdown list.

There's also a new regression: the top and bottom padding of the panel are different heights now.

Oh, I forgot there was no train this week. You can disregard my above comment.

Checking beta cluster, you might want to adjust the following:

• The font size of the panel is bigger than the other font sizes on the page.
• Clicking a filled in star with the panel open or closed, I'd expect it to perform an unwatch action (previous behavior). Instead it doesn't do anything.
• Clicking a not filled in star with the panel open, I'd expect it to perform a watch action (previous behavior). Instead it doesn't do anything.

Thanks for testing it!

The font size of the panel is bigger than the other font sizes on the page.

This looks like it's only happening in Vector. I'll make a fix for it.

Clicking a filled in star with the panel open or closed, I'd expect it to perform an unwatch action (previous behavior). Instead it doesn't do anything.

Removing one-click unwatching is intentional, because otherwise there's no way to change the expiry or labels of a watched page. There's a new unwatch button at the bottom of the popover.

Clicking a not filled in star with the panel open, I'd expect it to perform a watch action (previous behavior). Instead it doesn't do anything.

Yeah there's been some discussion about this, and it probably needs more work. If the popover is open, there is a watch button present. Earlier we had it close when clicking the star with the popover open (i.e. the star is basically a toggle that opens and closes the popover). But you're right, re-clicking the empty star could also serve to re-watch the page.

I think a good compromise might be having one click watchlisting and one click unwatchlisting, but also always open the panel. Then folks can still adjust labels if they want, or they can press the X in the panel to close it if they don't want the extra options. The benefit is it keeps the UI behavior that we're used to when clicking on the star.

That would be neater, but I think the issue is that if you click and it unwatches, then it'll have already discarded your labels and expiry when the panel opens. It's always been this way for expiry (i.e. it's never been possible to change an expiry without unwatching and rewatching) but that's not been an issue because the expiry is a single value and in that scenario you're trying to change it — with labels however, you might just want to add or remove a label from a set of half a dozen.

Clicking a not filled in star with the panel open, I'd expect it to perform a watch action (previous behavior). Instead it doesn't do anything.

I've fixed this up (in T423975) so that it closes the popup. It doesn't unwatch, for the reasons I gave above, but if you want we can revisit that later.

Where are you seeing it fixed? The new code hasn't been deployed yet! :)

Beta cluster.

Judging from your comment, sounds like your team likes to close tickets after deployment, so feel free to reopen :)

I wasn't thinking right! :) Of course. No, it can stay closed, I just thought that perhaps someone had applied a local workaround in common.css or something.