Page MenuHomePhabricator

Improve handling of import failures in TextMatch edit check
Closed, ResolvedPublic

Description

In T411662, we made it possible to import a matchitem (i.e., a text match rule) config file into the main editcheck json. For example, see how MediaWiki:Editcheck-config.json imports MediaWiki:Editcheck-config-textmatch-british-english.json.

Currently, if the API request used to import these configs fails for any reason, TextMatch errors out completely and none of the other matchitems are checked. This task is for making sure import errors do not affect the rest of the TextMatch work.

Requirements

  • Update TextMatch to gracefully handle import errors and continue checking for any of the matchitem configs that were successfully processed.

Event Timeline

Change #1270533 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/VisualEditor@master] TextMatch: handle an empty return from the config import fn

https://gerrit.wikimedia.org/r/1270533

Change #1270533 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] TextMatch: handle an empty return from the config import fn

https://gerrit.wikimedia.org/r/1270533

import errors do not affect the rest of the TextMatch work

image.png (1,434×412 px, 62 KB)

Errors handle gracefully