Page MenuHomePhabricator
Create Task
Maniphest T423071

ULS rewrite: Add direction (dir) to languages
Closed, ResolvedPublic4 Estimated Story Points
Actions

Assigned To
abi_
Authored By
abi_
Apr 13 2026, 7:30 AM
Project Tags
Referenced Files
F83159161: image.png
Thu, May 21, 11:57 AM
F83158170: image.png
Thu, May 21, 11:57 AM
F83157881: image.png
Thu, May 21, 11:57 AM
F79855007: image.png
May 5 2026, 11:35 PM
F78801587: image.png
Apr 30 2026, 6:41 AM
F77447161: image.png
Apr 23 2026, 9:59 AM
F76764201: image.png
Apr 20 2026, 12:07 PM
Subscribers
abi_
Aklapper
Nikerabbit

Description

The language items in the ULS rewrite do not have direction (dir) attribute specified right now. Now that we have the language-data library included in MediaWiki core, we can use it to add the direction.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ULS rewrite: Fix RTL title alignment in Chromemediawiki/extensions/UniversalLanguageSelectormaster+1 -1
ULS rewrite: Fix language item alignment in multi-column layoutmediawiki/extensions/UniversalLanguageSelectormaster+12 -20
ULS rewrite: Implement before/after marker support for language itemsmediawiki/extensions/UniversalLanguageSelectormaster+128 -24
ULS rewrite: Handle mixed directionality better for language itemsmediawiki/extensions/UniversalLanguageSelectormaster+7 -0
ULS rewrite: Add language direction to annotationsmediawiki/extensions/UniversalLanguageSelectormaster+52 -3
Customize query in gerrit

Event Timeline

abi_ created this task.Apr 13 2026, 7:30 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 13 2026, 7:30 AM
abi_ moved this task from Backlog to In Progress on the LPL Essential (FY2025-26 Q3&4) board.Apr 13 2026, 7:30 AM
gerritbot added a comment.Apr 13 2026, 8:19 AM

Change #1270364 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add langauge direction to annotations

https://gerrit.wikimedia.org/r/1270364

gerritbot added a project: Patch-For-Review.Apr 13 2026, 8:19 AM
gerritbot added a comment.Apr 15 2026, 9:09 AM

Change #1270364 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Add language direction to annotations

https://gerrit.wikimedia.org/r/1270364

Maintenance_bot removed a project: Patch-For-Review.Apr 15 2026, 9:30 AM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.26; 2026-04-28).Apr 15 2026, 10:00 AM
abi_ moved this task from In Progress to Pending Deployment on the LPL Essential (FY2025-26 Q3&4) board.Apr 15 2026, 12:24 PM
abi_ moved this task from Pending Deployment to In Progress on the LPL Essential (FY2025-26 Q3&4) board.Apr 20 2026, 12:07 PM

Source: https://bd4346ecd8.catalyst.wmcloud.org/wiki/ManyLanguages

image.png (853×593 px, 65 KB)

The direction causes the translation % icon to appear misaligned.

gerritbot added a comment.Apr 20 2026, 4:14 PM

Change #1275454 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Handle mixed directionality better for language items

https://gerrit.wikimedia.org/r/1275454

gerritbot added a project: Patch-For-Review.Apr 20 2026, 4:14 PM
gerritbot added a comment.Apr 21 2026, 12:00 PM

Change #1275454 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Handle mixed directionality better for language items

https://gerrit.wikimedia.org/r/1275454

Maintenance_bot removed a project: Patch-For-Review.Apr 21 2026, 12:30 PM
abi_ moved this task from In Progress to Pending Deployment on the LPL Essential (FY2025-26 Q3&4) board.Apr 23 2026, 5:02 AM
abi_ added a comment.EditedApr 23 2026, 9:59 AM

Source: https://bd4346ecd8.catalyst.wmcloud.org/wiki/FewLanguages

Issue with rtl direction languages has been fixed.

image.png (492×590 px, 29 KB)

abi_ moved this task from Pending Deployment to Need QA on the LPL Essential (FY2025-26 Q3&4) board.Apr 23 2026, 10:00 AM
Nikerabbit moved this task from Need QA to In Progress on the LPL Essential (FY2025-26 Q3&4) board.Apr 30 2026, 6:41 AM
Nikerabbit subscribed.

There is an oddity for multi-line items in RTL languages being left-aligned.

image.png (714×448 px, 36 KB)

gerritbot added a comment.May 5 2026, 11:35 PM

Change #1280499 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Implement before/after marker support for language items

https://gerrit.wikimedia.org/r/1280499

gerritbot added a project: Patch-For-Review.May 5 2026, 11:35 PM
abi_ added a comment.May 5 2026, 11:35 PM

With the patch: 1280499: ULS rewrite: Implement before/after marker support for language items | https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/1280499

image.png (593×446 px, 36 KB)

abi_ moved this task from Backlog to In progress on the LPL Projects (ULS rewrite) board.Thu, May 14, 8:28 AM
gerritbot added a comment.Mon, May 18, 7:33 AM

Change #1280499 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Implement before/after marker support for language items

https://gerrit.wikimedia.org/r/1280499

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).Mon, May 18, 8:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mon, May 18, 8:32 AM
abi_ moved this task from In Progress to Pending Deployment on the LPL Essential (FY2025-26 Q3&4) board.Tue, May 19, 8:09 AM
Nikerabbit moved this task from Pending Deployment to Need QA on the LPL Essential (FY2025-26 Q3&4) board.Thu, May 21, 11:46 AM
Nikerabbit moved this task from Need QA to In Progress on the LPL Essential (FY2025-26 Q3&4) board.Thu, May 21, 11:57 AM

From wmf.3 production:

LTR UI

image.png (721×458 px, 41 KB)

RTL UI

image.png (721×458 px, 33 KB)

Language items should be aligned to same edge, only text direction changing.

Compare with old ULS:

image.png (1,067×572 px, 49 KB)

Nikerabbit changed the point value for this task from 2 to 4.Thu, May 21, 11:59 AM
gerritbot added a comment.Sat, May 23, 12:40 AM

Change #1292343 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Fix language item alignment in multi-column layout

https://gerrit.wikimedia.org/r/1292343

gerritbot added a project: Patch-For-Review.Sat, May 23, 12:40 AM
gerritbot added a comment.Wed, May 27, 3:52 PM

Change #1292343 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Fix language item alignment in multi-column layout

https://gerrit.wikimedia.org/r/1292343

abi_ moved this task from In Progress to Pending Deployment on the LPL Essential (FY2025-26 Q3&4) board.Wed, May 27, 3:59 PM
Maintenance_bot removed a project: Patch-For-Review.Wed, May 27, 4:31 PM
Nikerabbit edited projects, added: MW-1.47-notes (1.47.0-wmf.5; 2026-06-02); removed: MW-1.47-notes (1.47.0-wmf.3; 2026-05-19).Thu, May 28, 8:19 AM
Nikerabbit moved this task from Pending Deployment to In Progress on the LPL Essential (FY2025-26 Q3&4) board.Tue, Jun 2, 7:43 AM
gerritbot added a comment.Tue, Jun 2, 9:37 AM

Change #1296515 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Fix RTL title alignment in Chrome

https://gerrit.wikimedia.org/r/1296515

gerritbot added a project: Patch-For-Review.Tue, Jun 2, 9:37 AM
gerritbot added a comment.Tue, Jun 2, 8:00 PM

Change #1296515 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] ULS rewrite: Fix RTL title alignment in Chrome

https://gerrit.wikimedia.org/r/1296515

Maintenance_bot removed a project: Patch-For-Review.Tue, Jun 2, 8:31 PM
abi_ moved this task from In Progress to Pending Deployment on the LPL Essential (FY2025-26 Q3&4) board.Wed, Jun 3, 6:33 AM
Nikerabbit closed this task as Resolved.Wed, Jun 3, 11:25 AM
Nikerabbit moved this task from Pending Deployment to Done on the LPL Essential (FY2025-26 Q3&4) board.

Tested locally in Chrome.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits