Description
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| deployment_server: move charlie/admin_ng to debian package | operations/puppet | production | +32 -601 |
Related Objects
Event Timeline
Wrapping my head around @RLazarus charlie.py, as it is "recursively searches out helmfile services in a given repository or subtree, identifies all the environments for each service, and diffs or applies them by shelling out to helmfile". It seems like the helmfile discovery is solved here, and it runs periodically, so it would be useful to make it generate metrics.
For all purposes, running charlie --dry_run --services_dir admin_ng diff produces the same information as check_admin_ng_pending_changes.py when invoked for all environments. I'm considering
- making it a library
- adding prometheus exporter to expose error code and maybe the chart versions
atsuko opened https://gitlab.wikimedia.org/repos/sre/charlie/-/merge_requests/1
Draft: Migrating charlie to a standalone repository
Code and history is copied to gitlab/sre/charlie, now there are two commands:
- /usr/bin/charlie that works like previous /usr/local/bin/charlie,
- /usr/local/bin/charlie-prom --services_dir admin_ng that inherits functionality of check_admin_ng_pending_changes.py.
atsuko merged https://gitlab.wikimedia.org/repos/sre/charlie/-/merge_requests/1
Generalising check_admin_ng_pending_changes.py with charlie
Change #1277471 had a related patch set uploaded (by Atsuko; author: Atsuko):
[operations/puppet@production] deployment_server: move charlie/admin_ng to debian package
Change #1277471 merged by Atsuko:
[operations/puppet@production] deployment_server: move charlie/admin_ng to debian package
Rolled out the replacement script, thanos helmfile_admin_ng_pending_changes didn't change. Going to roll it out for dse services as well now.
atsuko opened https://gitlab.wikimedia.org/repos/sre/charlie/-/merge_requests/2
prom: add service glob
atsuko merged https://gitlab.wikimedia.org/repos/sre/charlie/-/merge_requests/2
prom: add service glob