Page MenuHomePhabricator

Don't use user's ORES threshold preference when fetching damaging Recent Changes edits for PersonalDashboard
Closed, DeclinedPublic

Description

@Vydrakk noted that they viewed the Personal Dashboard without issue, then changed some preferences, after which they began seeing an error, instead of edits, in the Review Changes module.

They tested in Chrome and Firefox, tried disabling all Chrome extensions, and tried with ?safemode=1.

In Chrome:
Error: Cannot read properties of undefined (reading 'query')

image.png (744×473 px, 40 KB)

In Firefox:
Error: can't access property "query", rcData is undefined

image.png (829×552 px, 39 KB)

The preference they changed was setting the 'Prediction threshold' preference to 'Very likely have problems', which has to go much further back in Recent Changes to find enough edits to return. This sometimes caused timeouts, which results in this error.

It's not intuitive that this preference would impact interfaces other than Special:RecentChanges. Ideally we should be able to fetch high revert risk recent changes without ever considering what preferences the user has set.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Samwalton9-WMF renamed this task from Query error in Review Changes on PersonalDashboard to Don't use user's ORES threshold preference when fetching damaging Recent Changes edits for PersonalDashboard.Apr 13 2026, 2:37 PM
Samwalton9-WMF updated the task description. (Show Details)

We're discussing some other approaches for this. For example, we could fetch a larger number of recent changes and score them ourselves, then filter out edits below a given score. We used to do this, but it wasn't fetching many edits. This would be addressed if we resolved T419444.