Page MenuHomePhabricator

Handle All Errors thrown by fetching Recent Changes or Watched Changes
Closed, ResolvedPublic1 Estimated Story Points

Description

If we run into an error such as a timeout error seen in T423099: Don't use user's ORES threshold preference when fetching damaging Recent Changes edits for PersonalDashboard on any API request in the Review Changes module we shouldn't spread the undefined data into an object but throw a new Error with the code.
See screenshot below for error in debug console:

Screenshot 2026-04-13 at 3.43.07 PM.png (677×1 px, 298 KB)

Acceptance Criteria:
Fix error handling so that we're not spreading undefined into an object.
Update the handleApiErrors method to handle timeout errors

Event Timeline

Kgraessle triaged this task as High priority.
Kgraessle moved this task from To be estimated to Kanban on the Moderator-Tools-Team board.
Kgraessle moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
Kgraessle set the point value for this task to 1.
Kgraessle renamed this task from Don't spread undefined if Recent Changes or Watchlist API returns undefined to Handle All Errors thrown by fetching Recent Changes or Watched Changes.Apr 14 2026, 1:29 PM
Kgraessle updated the task description. (Show Details)

Change #1271628 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/PersonalDashboard@master] Handle All Errors thrown by fetching Recent Changes or Watched Changes

https://gerrit.wikimedia.org/r/1271628

Change #1271628 abandoned by Kgraessle:

[mediawiki/extensions/PersonalDashboard@master] Handle All Errors thrown by fetching Recent Changes or Watched Changes

Reason:

Wrong branch push

https://gerrit.wikimedia.org/r/1271628

Change #1272759 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/PersonalDashboard@master] Handle All Errors thrown by fetching Recent Changes or Watched Changes

https://gerrit.wikimedia.org/r/1272759

Change #1272759 merged by jenkins-bot:

[mediawiki/extensions/PersonalDashboard@master] Handle All Errors thrown by fetching Recent Changes or Watched Changes

https://gerrit.wikimedia.org/r/1272759

Kgraessle moved this task from QA to Done on the Moderator-Tools-Team (Kanban) board.

I validated that we're handling the timeout error.