Page MenuHomePhabricator
Create Task
Maniphest T423191

Damaged message UI requeues job messages with empty payload
Closed, DuplicatePublic
Actions

Description

ejegg: damaged message UI doesn't handle nested arrays so it just lost the payload. We should fix that!

2026-04-13 13:02:01,425 INFO ===========
2026-04-13 13:02:01,425 INFO /usr/bin/php -d display_errors=1 -d error_reporting=32767 /srv/www/org/wikimedia/listeners/SmashPig/Maintenance/QueueJobRunner.php --queue jobs-adyen --config-node adyen --message-limit 20000 --time-limit 175 (1747048)
2026-04-13 13:02:01,425 INFO -----------
2026-04-13 13:02:01,480 INFO 2026-04-13T13:02:01+00:00 [INFO ] {SmashPig-Adyen-QueueJobRunner::SPCID-0251117560} Message: {"class":"SmashPig\\PaymentProviders\\Adyen\\Jobs\\DownloadReportJob","payload":"","source_name":"CiviCRM","source_type":"direct","source_host":"civi1002","source_run_id":1740225,"source_version":"unknown","source_enqueued_time":1776085308}
2026-04-13 13:02:01,480 INFO 2026-04-13T13:02:01+00:00 [INFO ] {SmashPig-Adyen-QueueJobRunner::SPCID-0251117560} Hydrating a message with class SmashPig\PaymentProviders\Adyen\Jobs\DownloadReportJob
2026-04-13 13:02:01,507 INFO 2026-04-13T13:02:01+00:00 [ALERT ] {SmashPig-Adyen-QueueJobRunner::SPCID-0251117560} Last chance exception handler fired.
2026-04-13 13:02:01,507 INFO TypeError@/srv/www/org/wikimedia/listeners/SmashPig/Core/QueueConsumers/JobQueueConsumer.php:40 (Cannot assign string to property SmashPig\PaymentProviders\Adyen\Jobs\DownloadReportJob::$payload of type array)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
job message payload type checkwikimedia/fundraising/SmashPigmaster+2 -2
Customize query in gerrit

Event Timeline

AnnWF created this task.Mon, Apr 13, 6:50 PM
Restricted Application added a project: Fundraising-Backlog. · View Herald TranscriptMon, Apr 13, 6:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Mon, Apr 13, 6:57 PM

Change #1270516 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/SmashPig@master] job message payload type check

https://gerrit.wikimedia.org/r/1270516

gerritbot added a project: Patch-For-Review.Mon, Apr 13, 6:57 PM
AnnWF renamed this task from TypeError when payload is not an array to DownloadReportJob has empty payload, should be array.Mon, Apr 13, 7:03 PM
AnnWF updated the task description. (Show Details)
gerritbot added a comment.Mon, Apr 13, 7:03 PM

Change #1270516 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] job message payload type check

https://gerrit.wikimedia.org/r/1270516

Ejegg subscribed.Mon, Apr 13, 7:06 PM

Just to note that the thing I was saying we should fix is the damaged message UI, so it can display and re-submit nested array

AnnWF renamed this task from DownloadReportJob has empty payload, should be array to DownloadReportJob has empty payload, should be an array.Mon, Apr 13, 7:07 PM
AnnWF updated the task description. (Show Details)
Ejegg renamed this task from DownloadReportJob has empty payload, should be an array to Damaged message UI requeues job messages with empty payload.Mon, Apr 13, 7:08 PM
Maintenance_bot removed a project: Patch-For-Review.Mon, Apr 13, 7:30 PM
Ejegg closed this task as a duplicate of T205316: Damaged message UI breaks nested arrays on re-queue.Mon, Apr 13, 8:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits