Page MenuHomePhabricator

Rename unprefixed service keys to include `ReadingLists.` prefix
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

ServiceWiring.php registers two services without the ReadingLists. namespace prefix that all other extension services use:

  • ReverseInterwikiLookup (should be ReadingLists.ReverseInterwikiLookup)
  • UserPreferenceBatchUpdater (should be ReadingLists.UserPreferenceBatchUpdater)

Unprefixed service names risk collision with identically-named services from other extensions and make it harder to audit which services belong to this extension.

Goal

Rename both service keys to include the ReadingLists. prefix and update all call sites.

Acceptance criteria for done

  • Register ReadingLists.ReverseInterwikiLookup and ReadingLists.UserPreferenceBatchUpdater in ServiceWiring.php
  • Update all getService() calls referencing the old names

Event Timeline

Change #1270602 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/ReadingLists@master] ServiceWiring: Add prefixes to two services

https://gerrit.wikimedia.org/r/1270602

Change #1270602 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] ServiceWiring: Add prefixes to two services

https://gerrit.wikimedia.org/r/1270602

Volker_E set the point value for this task to 1.