Page MenuHomePhabricator
Create Task
Maniphest T423241

Thumbtime for TimedMedia no longer working
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Choose any video file, for example: Ikusgela - Matsuo Bashō.webm
  • Set up the desired thumbtime, for example: 16
  • The wikicode should be [[File:Ikusgela - Matsuo Bashō.webm|960px|center|thumbtime=16|Bideoa]]

What happens?: The thumb doesn't match the thumbtime. Changing the number gives the same thumbnail, so it seems that is not respecting the thumbtime anymore.

What should have happened instead?: The thumb should change accordingly.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Bump wikimedia/parsoid to 0.24.0-a2mediawiki/vendorwmf/1.47.0-wmf.1+14 K -14 K
Bump wikimedia/parsoid to 0.24.0-a2mediawiki/vendormaster+14 K -14 K
Unbreak passing seek to ApiQueryVideoInfomediawiki/extensions/TimedMediaHandlerREL1_46+4 -1
Unbreak passing seek to ApiQueryVideoInfomediawiki/extensions/TimedMediaHandlermaster+4 -1
[parsoid] Cast thumbtime to a stringmediawiki/coreREL1_46+3 -1
Cast thumbtime to a stringmediawiki/services/parsoidmaster+3 -1
[parsoid] Cast thumbtime to a stringmediawiki/coremaster+3 -1
Customize query in gerrit

Related Objects

Event Timeline

Theklan created this task.Apr 14 2026, 9:51 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 14 2026, 9:51 AM
Theklan added a project: TimedMediaHandler.Apr 14 2026, 9:52 AM
Aklapper renamed this task from Thumtime for TimedMedia no longer working to Thumbtime for TimedMedia no longer working.Apr 14 2026, 11:43 AM
Aklapper edited projects, added: Regression; removed: Thumbor.
Aklapper updated the task description. (Show Details)
Jdlrobson-WMF added a project: Reader Growth Team.Apr 14 2026, 4:21 PM
TheDJ added a parent task: T414805: FY 25/26 WE 5.4.10 Standard Thumbnail Sizes Only.EditedApr 14 2026, 5:19 PM
TheDJ subscribed.

Most limely broke due to the recent thumbnail standardization

Ladsgroup subscribed.Apr 15 2026, 12:07 AM

I'm trying to see what's going on. https://test.wikipedia.org/w/index.php?title=Ma%E2%80%8Bin_Page&oldid=737973 looks correct. The URL is this //upload.wikimedia.org/wikipedia/commons/thumb/6/66/Ikusgela_-_Matsuo_Bash%C5%8D.webm/960px-seek%3D16-Ikusgela_-_Matsuo_Bash%C5%8D.webm.jpg?utm_source=test.wikipedia.org&utm_campaign=parser which includes seek and the 16 in it as well.

grafik.png (959×646 px, 535 KB)

I changed it to 30s and it showed a different thumbnail.

I'm looking at the patches we made for thumb steps in TMH and I really can't see how https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TimedMediaHandler/+/1265416/3/includes/TimedMediaHandler.php could cause thumbtime to stop working. It's from somewhere else.

Maybe it was broken in the previous branch which is deployed to euwiki but now got fixed in the new version which is deployed on testwiki?

Kallichore subscribed.EditedApr 19 2026, 11:19 AM

I observed the problem with thumbtime too, but only with Parsoid.

Example: the migration tool for https://de.wikipedia.org/wiki/Benutzer:Kallichore/Parsoid_thumbtime shows a starting rocket on the left (t=36) for the legacy parser, while Parsoid shows the default thumb on the right.

@Ladsgroup https://test.wikipedia.org/wiki/Ma%E2%80%8Bin_Page?useparsoid=1 shows the problem. So the problem is clearly not fixed on testwiki.

Kallichore added a project: Parsoid.Apr 19 2026, 12:24 PM
TheDJ removed a parent task: T414805: FY 25/26 WE 5.4.10 Standard Thumbnail Sizes Only.Apr 19 2026, 2:02 PM
TheDJ edited projects, added: Content-Transform-Team; removed: Reader Growth Team.Apr 20 2026, 3:19 PM
Kallichore added a comment.Apr 21 2026, 10:41 AM

A comparison of the thumb URLs shows that "seek%3D36" is missing when using Parsoid:

Legacy parser : https://upload.wikimedia.org/wikipedia/commons/thumb/d/d7/STS-114-launch-Jul26-2005.ogv/250px-seek%3D36-STS-114-launch-Jul26-2005.ogv.jpg

Parsoid : https://upload.wikimedia.org/wikipedia/commons/thumb/d/d7/STS-114-launch-Jul26-2005.ogv/250px--STS-114-launch-Jul26-2005.ogv.jpg

I seems that Parsoid does not pass the thumbtime parameter to the thumbnail URL. I wonder if this is a regression or if it was never implemented for Parsoid.

TheDJ added a comment.Apr 21 2026, 11:33 AM
In T423241#11843401, @Kallichore wrote:

A comparison of the thumb URLs shows that "seek%3D36" is missing when using Parsoid:

Legacy parser : https://upload.wikimedia.org/wikipedia/commons/thumb/d/d7/STS-114-launch-Jul26-2005.ogv/250px-seek%3D36-STS-114-launch-Jul26-2005.ogv.jpg

Parsoid : https://upload.wikimedia.org/wikipedia/commons/thumb/d/d7/STS-114-launch-Jul26-2005.ogv/250px--STS-114-launch-Jul26-2005.ogv.jpg

I seems that Parsoid does not pass the thumbtime parameter to the thumbnail URL. I wonder if this is a regression or if it was never implemented for Parsoid.

It seems a regression as the parserTests testcases of TimedMediaHandler do show seek as a thumb url parameter for parsoid.

MSantos edited projects, added: Content-Transform-Team (Work In Progress); removed: Content-Transform-Team.Apr 23 2026, 2:26 PM
MSantos moved this task from Backlog to Needs Investigation on the Content-Transform-Team (Work In Progress) board.
MSantos moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.
ABreault-WMF claimed this task.Apr 28 2026, 6:57 PM
gerritbot added a comment.Apr 28 2026, 7:06 PM

Change #1278540 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] [parsoid] Cast thumbtime to a string

https://gerrit.wikimedia.org/r/1278540

gerritbot added a project: Patch-For-Review.Apr 28 2026, 7:06 PM
ABreault-WMF moved this task from Needs Investigation to Code Review on the Content-Transform-Team (Work In Progress) board.Apr 28 2026, 7:06 PM
gerritbot added a comment.Apr 28 2026, 7:12 PM

Change #1278544 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Cast thumbtime to a string

https://gerrit.wikimedia.org/r/1278544

ABreault-WMF triaged this task as High priority.Apr 28 2026, 7:13 PM
gerritbot added a comment.Apr 28 2026, 8:51 PM

Change #1278540 merged by jenkins-bot:

[mediawiki/core@master] [parsoid] Cast thumbtime to a string

https://gerrit.wikimedia.org/r/1278540

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.1; 2026-05-05).Apr 28 2026, 9:00 PM
gerritbot added a comment.Apr 28 2026, 9:32 PM

Change #1278629 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/TimedMediaHandler@master] Unbreak passing seek to ApiQueryVideoInfo

https://gerrit.wikimedia.org/r/1278629

gerritbot added a comment.Apr 28 2026, 10:08 PM

Change #1278544 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Cast thumbtime to a string

https://gerrit.wikimedia.org/r/1278544

gerritbot added a comment.Apr 28 2026, 10:51 PM

Change #1278688 had a related patch set uploaded (by Zabe; author: Arlolra):

[mediawiki/core@REL1_46] [parsoid] Cast thumbtime to a string

https://gerrit.wikimedia.org/r/1278688

gerritbot added a comment.Apr 28 2026, 11:54 PM

Change #1278688 merged by jenkins-bot:

[mediawiki/core@REL1_46] [parsoid] Cast thumbtime to a string

https://gerrit.wikimedia.org/r/1278688

ReleaseTaggerBot added a project: MW-1.46-notes.Apr 29 2026, 12:01 AM
gerritbot added a comment.Apr 29 2026, 5:32 AM

Change #1278629 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Unbreak passing seek to ApiQueryVideoInfo

https://gerrit.wikimedia.org/r/1278629

Maintenance_bot removed a project: Patch-For-Review.Apr 29 2026, 6:31 AM
gerritbot added a comment.Apr 29 2026, 2:18 PM

Change #1279374 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/TimedMediaHandler@REL1_46] Unbreak passing seek to ApiQueryVideoInfo

https://gerrit.wikimedia.org/r/1279374

gerritbot added a project: Patch-For-Review.Apr 29 2026, 2:18 PM
gerritbot added a comment.Apr 29 2026, 2:22 PM

Change #1279374 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@REL1_46] Unbreak passing seek to ApiQueryVideoInfo

https://gerrit.wikimedia.org/r/1279374

Maintenance_bot removed a project: Patch-For-Review.Apr 29 2026, 2:32 PM
Umherirrender closed this task as Resolved.Apr 29 2026, 5:54 PM
gerritbot added a comment.May 7 2026, 7:44 PM

Change #1284813 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284813

gerritbot added a project: Patch-For-Review.May 7 2026, 7:44 PM
gerritbot added a comment.May 7 2026, 8:02 PM

Change #1284813 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284813

gerritbot added a comment.May 7 2026, 8:16 PM

Change #1284832 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@wmf/1.47.0-wmf.1] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284832

gerritbot added a comment.May 7 2026, 9:07 PM

Change #1284832 merged by jenkins-bot:

[mediawiki/vendor@wmf/1.47.0-wmf.1] Bump wikimedia/parsoid to 0.24.0-a2

https://gerrit.wikimedia.org/r/1284832

Stashbot mentioned this in T368724: Rendering diff on broken link with template (visual diff testing).May 7 2026, 9:15 PM
Stashbot mentioned this in T424773: __NOCONTENTCONVERT__ is not honored in Parsoid.
Stashbot mentioned this in T319058: ParserTests defaults to wgAllowExternalImages=true.
Stashbot mentioned this in T424446: Space added for no reason.
Stashbot mentioned this in T420336: mw-parsoid improvements.
Stashbot mentioned this in T425008: WrapSectionState crash: Wikimedia\Assert\InvariantException: Invariant failed: Expected only language variants to be missing about ids..
Stashbot mentioned this in T425107: __TOC__ not showing up in Parsoid on Norwegian Bokmål village pump pages.
Stashbot mentioned this in T425056: 1.46.0-wmf.26 broke itwiki's Template:Divisa calcio.
Stashbot mentioned this in T425731: CTT tasks week of 2026-05-01.
Stashbot mentioned this in T373384: Parsoid doesn't properly handle double-underscore magic words.
Stashbot mentioned this in T423701: Serialize ContentHolder (or at least its fragments) in ParserOutput.

Mentioned in SAL (#wikimedia-operations) [2026-05-07T21:15:34Z] <cscott@deploy1003> Started scap sync-world: Backport for [[gerrit:1284828|Upgrading webonyx/graphql-php (v15.31.5 => v15.32.3)]], [[gerrit:1284834|composer.json: Update webonyx/graphql-php to ^15.32.3]], [[gerrit:1284832|Bump wikimedia/parsoid to 0.24.0-a2 (T319058 T368724 T373384 T420336 T423241 T423701 T424446 T424773 T425008 T425056 T425107 T425731)]], [[gerrit:1284837|Bump wikimedia/parsoid to 0.24.0-a2 (T425731)]

Stashbot added a comment.May 7 2026, 9:17 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-07T21:17:28Z] <cscott@deploy1003> cscott: Backport for [[gerrit:1284828|Upgrading webonyx/graphql-php (v15.31.5 => v15.32.3)]], [[gerrit:1284834|composer.json: Update webonyx/graphql-php to ^15.32.3]], [[gerrit:1284832|Bump wikimedia/parsoid to 0.24.0-a2 (T319058 T368724 T373384 T420336 T423241 T423701 T424446 T424773 T425008 T425056 T425107 T425731)]], [[gerrit:1284837|Bump wikimedia/parsoid to 0.24.0-a2 (T425731)]] synced to the t

Stashbot added a comment.May 7 2026, 9:27 PM

Mentioned in SAL (#wikimedia-operations) [2026-05-07T21:27:35Z] <cscott@deploy1003> Finished scap sync-world: Backport for [[gerrit:1284828|Upgrading webonyx/graphql-php (v15.31.5 => v15.32.3)]], [[gerrit:1284834|composer.json: Update webonyx/graphql-php to ^15.32.3]], [[gerrit:1284832|Bump wikimedia/parsoid to 0.24.0-a2 (T319058 T368724 T373384 T420336 T423241 T423701 T424446 T424773 T425008 T425056 T425107 T425731)]], [[gerrit:1284837|Bump wikimedia/parsoid to 0.24.0-a2 (T425731)

Maintenance_bot removed a project: Patch-For-Review.May 7 2026, 9:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits