Page MenuHomePhabricator

[Mobile][Dark Mode] "Edit full page" button renders white stripes
Open, Needs TriagePublicBUG REPORT

Description

This bug is about the "Edit full page" button introduced in https://phabricator.wikimedia.org/T409990

Steps to replicate the issue (include links if applicable):

  • choose "dark mode" in the setting
  • open the mobile visual editor for a "middle section" of an article

What happens?:

What should have happened instead?:

  • dark mode should be respected

Other information (browser name/version, screenshots, etc.):
*This has been reported in de.Wikipedia: https://de.wikipedia.org/wiki/Wikipedia:Technik/Werkstatt#Seltsame_Artefakte_im_Visual_Editor_in_der_mobilen_Ansicht

  • Also reported in Ruwiki discord, with these screenshots as examples:

image.png (1×627 px, 218 KB)

image.png (1×627 px, 383 KB)

Event Timeline

Hi! The skeleton backgrounds are hardcoded light hex values. I'd be happy to submit a small patch replacing them with @background-color-interactive, which should handle dark mode automatically via Codex design tokens. This also aligns with the original T409990 spec.

Change #1279239 had a related patch set uploaded (by HakanIST; author: HakanIST):

[mediawiki/extensions/VisualEditor@master] Fix dark mode for "Edit full page" skeleton lines

https://gerrit.wikimedia.org/r/1279239

Submitted a fix that replaces the 8 hardcoded hex values (#fcfcfc, #fafafa, #f7f7f7, #f4f4f4) with fade( @background-color-interactive, X% ). This uses the Codex design token which automatically adapts to dark mode, while preserving the original gradient fade effect via different opacity percentages.