Page MenuHomePhabricator

VisualEditor: Un-listing when the caret is at the end of the document throws an error
Closed, ResolvedPublic


Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:59 AM
bzimport set Reference to bz40339.


Uncaught TypeError: Cannot read property 'annotations' of undefined
ve.ui.ListButtonTool.unlist ve.ui.ListButtonTool.js:161
ve.ui.ListButtonTool.onClick ve.ui.ListButtonTool.js:177
VeUiButtonTool.tool.$.on.mouseup ve.ui.ButtonTool.js:40
jQuery.event.dispatch load.php:3060

The correct stack error for this is:
Uncaught TypeError: Cannot read property 'html/data-parsoid' of undefined ve.js:357
ve.compareObjects ve.js:357
ve.ui.ListButtonTool.list ve.ui.ListButtonTool.js:66
ve.ui.ListButtonTool.onClick ve.ui.ListButtonTool.js:175
VeUiButtonTool.tool.$.on.mouseup ve.ui.ButtonTool.js:40
jQuery.event.dispatch load.php:3060

Fixed in

Confirmed still an issue.

Pushing to next milestone as they did not make it to master by yesterday.

Reassigning to Trevor because Rob is out

Confirmed still a problem in master as of 2012-11-27; now is a properly-thrown error from

Uncaught Error: offset 26 is out of bounds
ve.ce.Surface.onSelectionChange ve.ce.Surface.js:260

Fixed in gerrit 36597.