Page MenuHomePhabricator

mw.FormDataTransport upload and uploadChunk failing in CI
Closed, ResolvedPublic

Description

See https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php83/64624/console

17:59:10 FAILED TESTS:
17:59:10   mw.FormDataTransport
17:59:10     ✖ upload
17:59:10       Firefox 140.0 (Linux 0.0.0)
17:59:10     Expected: "/api.php"
17:59:10     Actual: "/api.php?action=query"
17:59:10     @http://localhost:9876/load.php?modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cmoment%2Coojs%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows%2Cpinia%2Csinonjs%2Cvue%2Cvue-test-utils%7Cext.eventLogging%7Cext.eventLogging.metricsPlatform%7Cjquery.client%2ChighlightText%2ClengthLimit%2CmakeCollapsible%2Cspinner%2Ctablesorter%2CtextSelection%7Cjquery.makeCollapsible.styles%7Cjquery.spinner.styles%7Cjquery.tablesorter.styles%7Cmediawiki.DateFormatter%2CForeignApi%2CString%2CTitle%2CUri%2Capi%2Ccldr%2CconfirmCloseWindow%2Ccookie%2Cdeflate%2Cexperiments%2Cfeedback%2Cinspect%2CjqueryMsg%2Clanguage%2CmessagePoster%2Cqunit-testrunner%2Crouter%2Cstorage%2Ctemplate%2Ctoc%2Cuser%2Cutil%2CvisibleTimeout%2Cwidgets%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.language.grammar.testdata%7Cmediawiki.language.jqueryMsg.testdata%7Cmediawiki.language.months%2Ctestdata%7Cmediawiki.libs.jpegmeta%2Cpluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.pager.codex%7Cmediawiki.rcfilters.filters.ui%7Cmediawiki.special.block.codex%7Cmediawiki.template.mustache%7Cmediawiki.widgets.CategoryMultiselectWidget%2CDateInputWidget%2CMediaSearch%2CTable%2CUserInputWidget%2Cstyles%7Cmediawiki.widgets.DateInputWidget.styles%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-alerts%2Cicons-content%2Cicons-editing-advanced%2Cicons-editing-core%2Cicons-editing-styling%2Cicons-interactions%2Cicons-layout%2Cicons-location%2Cicons-media%2Cicons-moderation%2Cicons-movement%2Cindicators%7Cskins.vector.clientPreferences%7Ctest.EventLogging%2CMediaWiki%2CUpload%20Wizard%2CVector&version=14h9p:2831:512
17:59:10     
17:59:10 
17:59:10     ✖ uploadChunk
17:59:10       Firefox 140.0 (Linux 0.0.0)
17:59:10     Expected: "/api.php"
17:59:10     Actual: "/api.php?action=query"
17:59:10     @http://localhost:9876/load.php?modules=%40wikimedia%2Fcodex%2Ccodex-styles%2Cmoment%2Coojs%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows%2Cpinia%2Csinonjs%2Cvue%2Cvue-test-utils%7Cext.eventLogging%7Cext.eventLogging.metricsPlatform%7Cjquery.client%2ChighlightText%2ClengthLimit%2CmakeCollapsible%2Cspinner%2Ctablesorter%2CtextSelection%7Cjquery.makeCollapsible.styles%7Cjquery.spinner.styles%7Cjquery.tablesorter.styles%7Cmediawiki.DateFormatter%2CForeignApi%2CString%2CTitle%2CUri%2Capi%2Ccldr%2CconfirmCloseWindow%2Ccookie%2Cdeflate%2Cexperiments%2Cfeedback%2Cinspect%2CjqueryMsg%2Clanguage%2CmessagePoster%2Cqunit-testrunner%2Crouter%2Cstorage%2Ctemplate%2Ctoc%2Cuser%2Cutil%2CvisibleTimeout%2Cwidgets%7Cmediawiki.ForeignApi.core%7Cmediawiki.editfont.styles%7Cmediawiki.language.grammar.testdata%7Cmediawiki.language.jqueryMsg.testdata%7Cmediawiki.language.months%2Ctestdata%7Cmediawiki.libs.jpegmeta%2Cpluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.pager.codex%7Cmediawiki.rcfilters.filters.ui%7Cmediawiki.special.block.codex%7Cmediawiki.template.mustache%7Cmediawiki.widgets.CategoryMultiselectWidget%2CDateInputWidget%2CMediaSearch%2CTable%2CUserInputWidget%2Cstyles%7Cmediawiki.widgets.DateInputWidget.styles%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-alerts%2Cicons-content%2Cicons-editing-advanced%2Cicons-editing-core%2Cicons-editing-styling%2Cicons-interactions%2Cicons-layout%2Cicons-location%2Cicons-media%2Cicons-moderation%2Cicons-movement%2Cindicators%7Cskins.vector.clientPreferences%7Ctest.EventLogging%2CMediaWiki%2CUpload%20Wizard%2CVector&version=14h9p:2832:50

On my local using MediaWiki-Docker and Fresh, this is failing on the master branch.

The failure is preventing the merge of r1271103 which needs to go out before next Monday, April 20.

Event Timeline

I don't know who to ping here. UploadWizard has no code steward, and the author of the tests is @MarkTraceur who appears to be inactive.

Change #1271951 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/UploadWizard@master] QUnit: temporarily skip consistently failing upload tests

https://gerrit.wikimedia.org/r/1271951

Oh, hah, this is due to us making mw.Api splice in your query params. Let me fix.

Change #1271984 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/UploadWizard@master] mw.FormDataTransport.test: Update expected API call for POSTed calls

https://gerrit.wikimedia.org/r/1271984

Change #1271951 abandoned by MusikAnimal:

[mediawiki/extensions/UploadWizard@master] QUnit: temporarily skip consistently failing upload tests

Reason:

see Ic5ac39eef0029c517406a70c12788360c46367be

https://gerrit.wikimedia.org/r/1271951

Change #1271984 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@master] mw.FormDataTransport.test: Update expected API call for POSTed calls

https://gerrit.wikimedia.org/r/1271984

MusikAnimal assigned this task to Jdforrester-WMF.

Thanks for the help! :)

Change #1276012 had a related patch set uploaded (by MusikAnimal; author: Jforrester):

[mediawiki/extensions/UploadWizard@wmf/1.46.0-wmf.24] mw.FormDataTransport.test: Update expected API call for POSTed calls

https://gerrit.wikimedia.org/r/1276012

Change #1276012 merged by jenkins-bot:

[mediawiki/extensions/UploadWizard@wmf/1.46.0-wmf.24] mw.FormDataTransport.test: Update expected API call for POSTed calls

https://gerrit.wikimedia.org/r/1276012

Mentioned in SAL (#wikimedia-operations) [2026-04-21T20:51:09Z] <musikanimal@deploy1003> Started scap sync-world: Backport for [[gerrit:1276012|mw.FormDataTransport.test: Update expected API call for POSTed calls (T423529 T421288)]]

Mentioned in SAL (#wikimedia-operations) [2026-04-21T20:52:45Z] <musikanimal@deploy1003> musikanimal: Backport for [[gerrit:1276012|mw.FormDataTransport.test: Update expected API call for POSTed calls (T423529 T421288)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Mentioned in SAL (#wikimedia-operations) [2026-04-21T20:57:36Z] <musikanimal@deploy1003> Finished scap sync-world: Backport for [[gerrit:1276012|mw.FormDataTransport.test: Update expected API call for POSTed calls (T423529 T421288)]] (duration: 06m 27s)