Page MenuHomePhabricator

'trending' signal in the Attribution API is not returning the correct descriptions in the schema
Closed, ResolvedPublic1 Estimated Story Points

Description

Description

The schema defines the shape of the expected return objects and includes descriptions of the expected values. Right now, descriptions and expected types are all populated correctly, except for the trending object. Instead, the description is showing as `
⧼wikimediacustomizations-attribution-get-pages-signals-property-trending⧽`.

    1. Conditions of acceptance
  • 'top' should read: Indicates whether a Wikipedia article ranked among the project’s most read, most edited, or both over the last 24 hours.
    • Update read property description to: The page is currently in the top 1000 read pages for the wiki project.
    • Update edited property description to: The page is currently in the top 100 edited pages for the wiki project, based on number of edits.
    • Update read_and_edited property description to: The page is currently in the top 1000 read and top 100 edited pages for the wiki project.
  • 'relative' should read: Indicates the page is currently outperforming its average read and edit rates.
    • Update read property description to: The page is currently exceeding its average read rate.
    • Update edited property description to: The page currently has a higher rate of edits being submitted than its average.
    • Update read_and_edited property description to: The page currently has more read and edit activity than its average performance.

Event Timeline

HCoplin-WMF set the point value for this task to 1.Apr 16 2026, 3:47 PM

Notes from estimation:

  • The key is showing up without an en value. We're using them in code, but they're missing from the translation file (or has a typo in it).
  • Make a recommendation for introducing a systemic fix for catching these types of issues. Determine if it would be caught by banana testing, or something else. How might we catch missing strings, misspellings, etc?

Change #1272881 had a related patch set uploaded (by Pmiazga; author: Pmiazga):

[mediawiki/extensions/WikimediaCustomizations@master] Attribution: Add localized texts for trending param

https://gerrit.wikimedia.org/r/1272881

Change #1272881 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCustomizations@master] Attribution: Add localized texts for trending param

https://gerrit.wikimedia.org/r/1272881

Change #1275478 had a related patch set uploaded (by Pmiazga; author: Pmiazga):

[mediawiki/extensions/WikimediaCustomizations@wmf/1.46.0-wmf.24] Attribution: Add localized texts for trending param

https://gerrit.wikimedia.org/r/1275478

Change #1275478 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCustomizations@wmf/1.46.0-wmf.24] Attribution: Add localized texts for trending param

https://gerrit.wikimedia.org/r/1275478